sqlparser: extract goyacc into github.com/vitessio/goyacc (#19706)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: arthurschreiber

.golangci.yml

@@ -43,10 +43,9 @@ linters:
           list-mode: lax
           files:
             - "**/go/vt/sqlparser/**"
-            - "!**/go/vt/sqlparser/goyacc/**"
           deny:
             - pkg: github.com/spf13/pflag
-              desc: "sqlparser package should not depend on pflag except in goyacc subpackage - this component should be usable as a library with explicit configuration, not global flags"
+              desc: "sqlparser package should not depend on pflag - this component should be usable as a library with explicit configuration, not global flags"
             - pkg: vitess.io/vitess/go/vt/servenv
               desc: "sqlparser should not depend on servenv - this component should be usable as a library without server infrastructure dependencies"
         schemadiff_package_restrictions:
@@ -163,9 +162,6 @@ linters:
       - linters:
           - errcheck
         path: ^go/vt/sqlparser/(ast_format|ast_format_fast).go
-      - linters:
-          - errcheck
-        path: ^go/vt/sqlparser/goyacc
       - linters:
           - errcheck
         path: ^go/vt/throttler/.*_test.go

go.mod

@@ -3,6 +3,7 @@ module vitess.io/vitess
 go 1.26.1
 
 tool (
+	github.com/vitessio/goyacc
 	gotest.tools/gotestsum
 	mvdan.cc/gofumpt
 )
@@ -162,6 +163,7 @@ require (
 	github.com/sirupsen/logrus v1.9.3 // indirect
 	github.com/theckman/httpforwarded v0.4.0 // indirect
 	github.com/vbatts/tar-split v0.12.2 // indirect
+	github.com/vitessio/goyacc v0.0.0-20260324145439-055d41417f4e // indirect
 	go.opentelemetry.io/collector/component v1.42.0 // indirect
 	go.opentelemetry.io/collector/featuregate v1.42.0 // indirect
 	go.opentelemetry.io/collector/internal/telemetry v0.136.0 // indirect

go.sum

@@ -616,6 +616,8 @@ github.com/uber/jaeger-lib v2.4.1+incompatible h1:td4jdvLcExb4cBISKIpHuGoVXh+dVK
 github.com/uber/jaeger-lib v2.4.1+incompatible/go.mod h1:ComeNDZlWwrWnDv8aPp0Ba6+uUTzImX/AauajbLI56U=
 github.com/vbatts/tar-split v0.12.2 h1:w/Y6tjxpeiFMR47yzZPlPj/FcPLpXbTUi/9H7d3CPa4=
 github.com/vbatts/tar-split v0.12.2/go.mod h1:eF6B6i6ftWQcDqEn3/iGFRFRo8cBIMSJVOpnNdfTMFA=
+github.com/vitessio/goyacc v0.0.0-20260324145439-055d41417f4e h1:Pq1r4srNEsHShNMe/lMSSJYae8rWWtg9QEBLSIb1Np0=
+github.com/vitessio/goyacc v0.0.0-20260324145439-055d41417f4e/go.mod h1:w29qJNNyzpk4XIcE7g1WwTiv2uCBVaQPFoE5p6mZG+0=
 github.com/vmihailenco/msgpack/v4 v4.3.13 h1:A2wsiTbvp63ilDaWmsk2wjx6xZdxQOvpiNlKBGKKXKI=
 github.com/vmihailenco/msgpack/v4 v4.3.13/go.mod h1:gborTTJjAo/GWTqqRjrLCn9pgNN+NXzzngzBKDPIqw4=
 github.com/vmihailenco/tagparser v0.1.2 h1:gnjoVuB/kljJ5wICEEOpx98oXMWPLj22G67Vbd1qPqc=

go/vt/sqlparser/generate.go

@@ -18,6 +18,8 @@ package sqlparser
 
 // Generate all the AST helpers using the tooling in `go/tools`
 
-//go:generate go run ./goyacc -fo sql.go sql.y
+//go:generate go run github.com/vitessio/goyacc -fo sql.go sql.y
+//go:generate go run golang.org/x/tools/cmd/goimports@034e59c473362f8f2be47694d98fd3f12a1ad497 -local vitess.io/vitess -w sql.go
+//go:generate go tool gofumpt -w sql.go
 //go:generate go run ../../tools/asthelpergen/main  --in . --iface vitess.io/vitess/go/vt/sqlparser.SQLNode --clone_exclude "*ColName" --equals_custom "*ColName"
 //go:generate go run ../../tools/astfmtgen vitess.io/vitess/go/vt/sqlparser/...