Add pylint

Author: Ayala Shachar

.pylintrc

@@ -0,0 +1,8 @@
+[MESSAGES CONTROL]
+disable= R,attribute-defined-outside-init,bad-continuation,bad-option-value,bare-except,invalid-name,locally-disabled,missing-docstring,redefined-builtin,ungrouped-imports,wrong-import-order,wrong-import-position,unnecessary-pass,global-statement
+
+[REPORTS]
+reports=no
+
+[FORMAT]
+max-line-length=150

Makefile

@@ -1,7 +1,8 @@
 default: test
 
 test: env
-	.env/bin/py.test tests
+	.env/bin/pytest tests
+	.env/bin/pylint --rcfile .pylintrc flask_loopback tests setup.py
 
 env: .env/.up-to-date
 

flask_loopback/_compat.py

@@ -1,3 +1,4 @@
+# pylint: disable=import-error,unused-import
 from contextlib import contextmanager
 import gzip
 import sys

flask_loopback/flask_loopback.py

@@ -77,7 +77,7 @@ def handle_request(self, session, url, request):
                     return e.response
 
             self._test_client.cookie_jar.clear()
-            for cookie in request._cookies:
+            for cookie in request._cookies:  # pylint: disable=protected-access
                 self._test_client.cookie_jar.set_cookie(cookie)
             resp = self._test_client.open(path, **open_kwargs)
             returned = requests.Response()

setup.cfg

@@ -17,6 +17,10 @@ url = https://github.com/vmalloc/flask-loopback
 [extras]
 testing =
     pytest
+    astroid~=1.5.3; python_version=='2.7'
+    astroid>=2.0; python_version >= '3.4'
+    pylint~=1.7.2; python_version=='2.7'
+    pylint~=2.3.1; python_version >= '3.4'
 
 [tool:pytest]
 testpaths = tests

tests/conftest.py

@@ -1,4 +1,3 @@
-import gzip
 import hashlib
 
 import pytest

tests/test_flask_loopback.py

@@ -15,6 +15,7 @@
 _g_counter = 0
 
 def create_sample_app():
+    # pylint: disable=unused-variable
     returned = flask.Flask(__name__)
 
     @returned.route("/sample/url")
@@ -36,6 +37,7 @@ def get_remote_addr():
     return returned, l
 
 class FlaskLoopbackActivationTest(TestCase):
+    # pylint: disable=protected-access
 
     def setUp(self):
         super(FlaskLoopbackActivationTest, self).setUp()
@@ -45,9 +47,9 @@ def setUp(self):
         self.loopback.activate_address(("b.com", 1234))
 
     def test_deactivate_one_by_one(self):
-        self.assertEquals(len(dispatch._registered_addresses), 2)
+        self.assertEqual(len(dispatch._registered_addresses), 2)
         self.loopback.deactivate_address(("a.com", 123))
-        self.assertEquals(len(dispatch._registered_addresses), 1)
+        self.assertEqual(len(dispatch._registered_addresses), 1)
         with self.assertRaises(LookupError):
             self.loopback.deactivate_address(("a.com", 123))
         self.loopback.deactivate_address(("b.com", 1234))
@@ -65,18 +67,18 @@ def setUp(self):
         self.address = ("somehost.com", 1234)
         self.root_url = _url(self.address)
         self._ctx = self.loopback.on(self.address)
-        ctx_result = self._ctx.__enter__()
+        ctx_result = self._ctx.__enter__()  # pylint: disable=unused-variable
         self.addCleanup(self._ctx.__exit__, None, None, None)
 
     def test_simple_request(self):
-        self.assertEquals(requests.get(self.root_url.add_path("/sample/url")).content.decode("utf-8"), OK_RESPONSE)
+        self.assertEqual(requests.get(self.root_url.add_path("/sample/url")).content.decode("utf-8"), OK_RESPONSE)
 
     def test_response_attributes(self):
         url = self.root_url
         response = requests.get(url)
-        self.assertEquals(response.url, url)
-        self.assertEquals(response.request.url, url)
-        self.assertEquals(response.request.method, "GET")
+        self.assertEqual(response.url, url)
+        self.assertEqual(response.request.url, url)
+        self.assertEqual(response.request.method, "GET")
 
     def test_remote_addr(self):
         response = requests.get(self.root_url.add_path('remote_addr'))
@@ -85,35 +87,35 @@ def test_remote_addr(self):
 
     def test_not_found(self):
         response = requests.get(self.root_url.add_path("not_found"))
-        self.assertEquals(response.status_code, httplib.NOT_FOUND)
-        self.assertEquals(response.reason, "Not Found")
+        self.assertEqual(response.status_code, httplib.NOT_FOUND)
+        self.assertEqual(response.reason, "Not Found")
 
     def test_request_context_handler(self):
         initial_counter = _g_counter
 
         @self.loopback.register_request_context_handler
         @contextmanager
-        def increase_counter(request):
+        def increase_counter(request):  # pylint: disable=unused-argument,unused-variable
             global _g_counter
             _g_counter += 1
             yield
             _g_counter += 1
 
         returned = requests.get(self.root_url.add_path("increase_counter")).json()["result"]
-        self.assertEquals(_g_counter, initial_counter + 3)
-        self.assertEquals(returned, initial_counter + 2)
+        self.assertEqual(_g_counter, initial_counter + 3)
+        self.assertEqual(returned, initial_counter + 2)
 
     def test_request_context_handler_custom_response(self):
         initial_counter = _g_counter
 
         @self.loopback.register_request_context_handler
         @contextmanager
-        def return_custom_code(request):
+        def return_custom_code(request):  # pylint: disable=unused-variable
             raise CustomHTTPResponse(request, 666)
 
         response = requests.get(self.root_url.add_path("increase_counter"))
         assert response.status_code == 666
-        self.assertEquals(_g_counter, initial_counter)
+        self.assertEqual(_g_counter, initial_counter)
         self.assertIsNone(response.content)
 
 

tests/test_readme.py

@@ -2,9 +2,10 @@
 import os
 import doctest
 
+
 class ReadMeDocTest(TestCase):
     def test_readme_doctests(self):
         readme_path = os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "README.md"))
         self.assertTrue(os.path.exists(readme_path))
         result = doctest.testfile(readme_path, module_relative=False)
-        self.assertEquals(result.failed, 0, "%s tests failed!" % result.failed)
+        self.assertEqual(result.failed, 0, "%s tests failed!" % result.failed)

tests/test_request_attributes.py

@@ -1,4 +1,7 @@
+import pytest
 import requests
 
-def test_request_host(active_app, url):
+
+@pytest.mark.usefixtures('active_app')
+def test_request_host(url):
     assert requests.get(url.add_path('request_vars')).json()['host'] == url.netloc

tests/test_ssl.py

@@ -1,15 +1,15 @@
 import ssl
-
 import requests
-
 import pytest
 
 
-def test_ssl_fails_for_non_ssl_port(active_app, hostname, ssl_port, non_ssl_port):
+@pytest.mark.usefixtures('active_app', 'ssl_port')
+def test_ssl_fails_for_non_ssl_port(hostname, non_ssl_port):
     with pytest.raises(ssl.SSLError):
         requests.get("https://{0}:{1}".format(hostname, non_ssl_port))
 
-def test_non_ssl_fails_for_ssl_port(active_app, hostname, ssl_port, non_ssl_port):
+
+@pytest.mark.usefixtures('active_app', 'non_ssl_port')
+def test_non_ssl_fails_for_ssl_port(hostname, ssl_port):
     with pytest.raises(requests.ConnectionError):
         requests.get("http://{0}:{1}".format(hostname, ssl_port))
-