Clear up nullability

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

Author: AdamGS

encodings/parquet-variant/src/array.rs

@@ -15,7 +15,6 @@ use vortex_array::arrays::VariantArray;
 use vortex_array::arrow::ArrowArrayExecutor;
 use vortex_array::arrow::FromArrowArray;
 use vortex_array::dtype::DType;
-use vortex_array::dtype::Nullability;
 use vortex_array::stats::ArrayStats;
 use vortex_array::validity::Validity;
 use vortex_buffer::BitBuffer;
@@ -148,7 +147,7 @@ impl ParquetVariantArray {
                     Validity::from(BitBuffer::from(nulls.inner().clone()))
                 }
             })
-            .unwrap_or(Validity::AllValid);
+            .unwrap_or(Validity::NonNullable);
         let metadata =
             ArrayRef::from_arrow(arrow_variant.metadata_field() as &dyn ArrowArray, false)?;
 
@@ -162,14 +161,9 @@ impl ParquetVariantArray {
             .map(|tv| ArrayRef::from_arrow(tv.as_ref(), typed_value_nullable))
             .transpose()?;
 
-        let nullability = if matches!(validity, Validity::NonNullable | Validity::AllValid) {
-            Nullability::NonNullable
-        } else {
-            Nullability::Nullable
-        };
         let pv =
             ParquetVariantArray::try_new_with_validity(validity, metadata, value, typed_value)?;
-        Ok(VariantArray::new(pv.into_array(), nullability).into_array())
+        Ok(VariantArray::new(pv.into_array()).into_array())
     }
 
     /// Converts this array back to an Arrow [`parquet_variant_compute::VariantArray`].

encodings/parquet-variant/src/vtable.rs

@@ -270,7 +270,7 @@ impl VTable for ParquetVariant {
         );
 
         let (validity, mut child_idx) = if children.len() == expected_children {
-            (Validity::AllValid, 0)
+            (Validity::from(dtype.nullability()), 0)
         } else {
             (Validity::Array(children.get(0, &Validity::DTYPE, len)?), 1)
         };
@@ -338,9 +338,8 @@ impl VTable for ParquetVariant {
     }
 
     fn execute(array: Arc<Self::Array>, _ctx: &mut ExecutionCtx) -> VortexResult<ExecutionResult> {
-        let nullability = array.dtype.nullability();
         Ok(ExecutionResult::done(
-            VariantArray::new(array.as_ref().clone().into_array(), nullability).into_array(),
+            VariantArray::new(array.as_ref().clone().into_array()).into_array(),
         ))
     }
 }
@@ -402,8 +401,7 @@ mod tests {
         let inner_value = VarBinViewArray::from_iter_bin([b"\x02", b"\x03", b"\x04"]).into_array();
         let inner_pv =
             ParquetVariantArray::try_new(inner_metadata, Some(inner_value), None).unwrap();
-        let typed_value =
-            VariantArray::new(inner_pv.into_array(), Nullability::NonNullable).into_array();
+        let typed_value = VariantArray::new(inner_pv.into_array()).into_array();
 
         let outer_pv =
             ParquetVariantArray::try_new(outer_metadata, None, Some(typed_value)).unwrap();
@@ -413,7 +411,7 @@ mod tests {
         assert!(array.array_eq(&decoded, Precision::Value));
         let decoded_pv = decoded.as_opt::<ParquetVariant>().unwrap();
         let typed = decoded_pv.typed_value_array().unwrap();
-        assert_eq!(typed.dtype(), &DType::Variant(Nullability::NonNullable));
+        assert_eq!(typed.dtype(), &DType::Variant(Nullability::Nullable));
     }
 
     #[test]