Fix bug where empty string is a valid focusKey

vovacodes · vovacodes · commit 5ffc39b7754c · 2021-09-02T17:08:32.000+02:00
diff --git a/packages/react-sunbeam/package.json b/packages/react-sunbeam/package.json
@@ -1,6 +1,6 @@
 {
     "name": "react-sunbeam",
-    "version": "2.0.0-beta.2",
+    "version": "2.0.0-beta.3",
     "description": "Spatial navigation and focus management for React",
     "keywords": [
         "spatial-navigation",
diff --git a/packages/react-sunbeam/src/focus/FocusableNode.ts b/packages/react-sunbeam/src/focus/FocusableNode.ts
@@ -31,7 +31,7 @@ export class FocusableNode implements IFocusableNode {
         customGetPreferredChild?: CustomGetPreferredChildFn
         lock: Direction[] | Direction | undefined
     }) {
-        focusKey = focusKey ?? `focusable:${randomId()}`
+        focusKey = focusKey || `focusable:${randomId()}`
         this.focusKey = focusKey
         this.path = [...parentPath, focusKey]
         this.getBoundingBox = getBoundingBox

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "react-sunbeam",`
`3`		`- "version": "2.0.0-beta.2",`
	`3`	`+ "version": "2.0.0-beta.3",`
`4`	`4`	`"description": "Spatial navigation and focus management for React",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"spatial-navigation",`