Upgrade lints and fix issues

Author: Rexios80

vrchat_dart/example/pubspec.yaml

@@ -11,7 +11,7 @@ dependencies:
   otp: ^3.1.3
 
 dev_dependencies:
-  rexios_lints: ^10.0.1
+  rexios_lints: ^11.0.4
 
 dependency_overrides:
   vrchat_dart_generated:

vrchat_dart/example_flutter/lib/vrc_api_container.dart

@@ -6,7 +6,7 @@ import 'package:vrchat_dart/vrchat_dart.dart';
 class VrcApiContainer {
   /// I do not recommend storing a reference to [VrchatDart.api] or you will
   /// have a bad time with the type checker and conditional imports
-  Future<VrchatDart> create() async {
+  Future<VrchatDart> create() {
     return VrcApiContainerImpl().create();
   }
 }

vrchat_dart/example_flutter/pubspec.yaml

@@ -15,7 +15,7 @@ dependencies:
   package_info_plus: ^8.0.0
 
 dev_dependencies:
-  rexios_lints: ^10.0.1
+  rexios_lints: ^11.0.4
 
 dependency_overrides:
   vrchat_dart_generated:

vrchat_dart/lib/src/api/vrc_api_base.dart

@@ -5,8 +5,10 @@ import 'package:vrchat_dart/src/api/src/auth_api.dart';
 import 'package:vrchat_dart/src/streaming/vrc_streaming.dart';
 import 'package:vrchat_dart/src/api/vrc_api_native.dart'
     if (dart.library.js) 'package:vrchat_dart/src/api/vrc_api_web.dart';
+import 'package:meta/meta.dart';
 
 /// Shared code between the web and native implementations
+@immutable
 abstract class VrcApi {
   /// Access to auth convenience methods
   final AuthApi auth;

vrchat_dart/lib/src/model/api/vrc_response.dart

@@ -1,7 +1,9 @@
 import 'package:dio/dio.dart';
 import 'package:dio_response_validator/dio_response_validator.dart';
+import 'package:meta/meta.dart';
 
 /// A response from the auth API
+@immutable
 class AuthResponse {
   /// True if this account requires two factor auth
   final bool requiresTwoFactorAuth;
@@ -28,6 +30,7 @@ enum TwoFactorAuthType {
 }
 
 /// An error returned from the VRChat API
+@immutable
 class VrcError {
   /// Error message returned from the API
   final String message;
@@ -36,7 +39,7 @@ class VrcError {
   final int statusCode;
 
   /// Create a custom [VrcError]
-  VrcError({required this.message, required this.statusCode});
+  const VrcError({required this.message, required this.statusCode});
 
   /// Construct a [VrcError] from json
   static VrcError? fromDioError(DioException error) {

vrchat_dart/lib/src/model/streaming/streamed_current_user.dart

@@ -1,9 +1,11 @@
 import 'package:json_annotation/json_annotation.dart';
 import 'package:vrchat_dart_generated/vrchat_dart_generated.dart';
+import 'package:meta/meta.dart';
 
 part 'streamed_current_user.g.dart';
 
 /// A user object representing the signed in user streamed from the VRChat websocket connection
+@immutable
 @JsonSerializable()
 class StreamedCurrentUser {
   /// The user's bio
@@ -49,7 +51,7 @@ class StreamedCurrentUser {
   final String username;
 
   /// Create a [StreamedCurrentUser]
-  StreamedCurrentUser({
+  const StreamedCurrentUser({
     required this.bio,
     required this.currentAvatar,
     required this.currentAvatarAssetUrl,

vrchat_dart/lib/src/model/streaming/vrc_streaming_event.dart

@@ -2,6 +2,7 @@ import 'package:json_annotation/json_annotation.dart';
 import 'package:vrchat_dart/src/model/streaming/serializers.dart';
 import 'package:vrchat_dart_generated/vrchat_dart_generated.dart';
 import 'package:vrchat_dart/src/model/streaming/streamed_current_user.dart';
+import 'package:meta/meta.dart';
 
 part 'vrc_streaming_event.g.dart';
 
@@ -96,14 +97,19 @@ extension VrcStreamingEventTypeExtension on VrcStreamingEventType {
 }
 
 /// Base class for [VrcStreamingEvent]s
+@immutable
 abstract class VrcStreamingEvent {
   /// The type of [VrcStreamingEvent] received
   VrcStreamingEventType get type;
+
+  /// Constructor
+  const VrcStreamingEvent();
 }
 
 /// These shouldn't happen unless VRChat adds more events
 ///
 /// If you end up getting [UnknownEvent]s please create an issue on GitHub
+///
 class UnknownEvent extends VrcStreamingEvent {
   @override
   VrcStreamingEventType get type => VrcStreamingEventType.unknown;
@@ -112,7 +118,7 @@ class UnknownEvent extends VrcStreamingEvent {
   final String rawString;
 
   /// Create an [UnknownEvent] with the given [rawString]
-  UnknownEvent({required this.rawString});
+  const UnknownEvent({required this.rawString});
 }
 
 /// An error message returned from the server
@@ -121,7 +127,7 @@ class ErrorEvent extends VrcStreamingEvent {
   VrcStreamingEventType get type => VrcStreamingEventType.error;
 
   /// Create an [ErrorEvent] with the given [message]
-  ErrorEvent({required this.message});
+  const ErrorEvent({required this.message});
 
   /// The error message
   final String message;
@@ -133,7 +139,7 @@ abstract class FriendEvent extends VrcStreamingEvent {
   final String userId;
 
   /// Create a [FriendEvent] with the given [userId]
-  FriendEvent({required this.userId});
+  const FriendEvent({required this.userId});
 }
 
 /// Base class for [FriendEvent]s that contain a user object
@@ -142,7 +148,7 @@ abstract class FriendEventWithUser extends FriendEvent {
   final User user;
 
   /// Create a [FriendEventWithUser] with the given [userId] and [user]
-  FriendEventWithUser({required super.userId, required this.user});
+  const FriendEventWithUser({required super.userId, required this.user});
 }
 
 /// Base class for [UserEvent]s
@@ -151,7 +157,7 @@ abstract class UserEvent extends VrcStreamingEvent {
   final String userId;
 
   /// Create a [UserEvent] with the given [userId]
-  UserEvent({required this.userId});
+  const UserEvent({required this.userId});
 }
 
 /// Base class for [NotificationEvent]s
@@ -179,7 +185,7 @@ class FriendOnlineEvent extends FriendEventWithUser {
   final bool canRequestInvite;
 
   /// Create a [FriendOnlineEvent]
-  FriendOnlineEvent({
+  const FriendOnlineEvent({
     required super.userId,
     required super.user,
     required this.world,
@@ -204,7 +210,7 @@ class FriendOfflineEvent extends FriendEvent {
   VrcStreamingEventType get type => VrcStreamingEventType.friendOffline;
 
   /// Create a [FriendOnlineEvent] with the given [userId]
-  FriendOfflineEvent({required super.userId});
+  const FriendOfflineEvent({required super.userId});
 
   /// Create a [FriendOfflineEvent] from json
   factory FriendOfflineEvent.fromJson(Map<String, dynamic> json) =>
@@ -222,7 +228,7 @@ class FriendActiveEvent extends FriendEventWithUser {
   VrcStreamingEventType get type => VrcStreamingEventType.friendActive;
 
   /// Create a [FriendActiveEvent] with the given [userId] and [user]
-  FriendActiveEvent({required super.userId, required super.user});
+  const FriendActiveEvent({required super.userId, required super.user});
 
   /// Create a [FriendActiveEvent] from json
   factory FriendActiveEvent.fromJson(Map<String, dynamic> json) =>
@@ -240,7 +246,7 @@ class FriendAddEvent extends FriendEventWithUser {
   VrcStreamingEventType get type => VrcStreamingEventType.friendAdd;
 
   /// Create a [FriendAddEvent] with the given [userId] and [user]
-  FriendAddEvent({required super.userId, required super.user});
+  const FriendAddEvent({required super.userId, required super.user});
 
   /// Create a [FriendAddEvent] from json
   factory FriendAddEvent.fromJson(Map<String, dynamic> json) =>
@@ -258,7 +264,7 @@ class FriendDeleteEvent extends FriendEvent {
   VrcStreamingEventType get type => VrcStreamingEventType.friendDelete;
 
   /// Create a [FriendDeleteEvent] with the given [userId]
-  FriendDeleteEvent({required super.userId});
+  const FriendDeleteEvent({required super.userId});
 
   /// Create a [FriendDeleteEvent] from json
   factory FriendDeleteEvent.fromJson(Map<String, dynamic> json) =>
@@ -276,7 +282,7 @@ class FriendUpdateEvent extends FriendEventWithUser {
   VrcStreamingEventType get type => VrcStreamingEventType.friendUpdate;
 
   /// Create a [FriendUpdateEvent] with the given [userId] and [user]
-  FriendUpdateEvent({required super.userId, required super.user});
+  const FriendUpdateEvent({required super.userId, required super.user});
 
   /// Create a [FriendUpdateEvent] from json
   factory FriendUpdateEvent.fromJson(Map<String, dynamic> json) =>
@@ -308,7 +314,7 @@ class FriendLocationEvent extends FriendEventWithUser {
   final bool canRequestInvite;
 
   /// Create a [FriendLocationEvent]
-  FriendLocationEvent({
+  const FriendLocationEvent({
     required super.userId,
     required super.user,
     required this.world,
@@ -339,7 +345,7 @@ class UserUpdateEvent extends UserEvent {
   final StreamedCurrentUser user;
 
   /// Create a [UserUpdateEvent] with the given [userId] and [user]
-  UserUpdateEvent({required super.userId, required this.user});
+  const UserUpdateEvent({required super.userId, required this.user});
 
   /// Create a [UserUpdateEvent] from json
   factory UserUpdateEvent.fromJson(Map<String, dynamic> json) =>
@@ -365,7 +371,7 @@ class UserLocationEvent extends UserEvent {
   final String instance;
 
   /// Create a [UserLocationEvent]
-  UserLocationEvent({
+  const UserLocationEvent({
     required super.userId,
     required this.world,
     required this.location,

vrchat_dart/lib/src/model/vrchat_user_agent.dart

@@ -1,10 +1,13 @@
+import 'package:meta/meta.dart';
+
 /// A user agent that satisfies the VRChat guidelines
 ///
 /// > Applications must identify themselves properly using the User-Agent
 /// > request header. Use this format: `applicationName/Version contactInfo`.
 /// > For example: `VRCAPIApp/1.5.1 contact@example.com`. Failing to identify
 /// > yourself clearly or identifying yourself improperly will result in
 /// > moderation action.
+@immutable
 class VrchatUserAgent {
   /// The name of this application
   final String applicationName;

vrchat_dart/lib/src/streaming/vrc_streaming.dart

@@ -21,7 +21,7 @@ class VrcStreaming {
   final VrchatDartGenerated _rawApi;
   final String _baseUrl;
 
-  bool _started = false;
+  var _started = false;
   WebSocketChannel? _channel;
 
   /// Create a [VrcStreaming] instance

vrchat_dart/lib/src/vrchat_dart_base.dart

@@ -4,8 +4,10 @@ import 'package:vrchat_dart_generated/vrchat_dart_generated.dart';
 import 'package:vrchat_dart/src/api/src/auth_api.dart';
 import 'package:vrchat_dart/src/api/vrc_api_base.dart';
 import 'package:vrchat_dart/src/streaming/vrc_streaming.dart';
+import 'package:meta/meta.dart';
 
 /// VrchatDart
+@immutable
 class VrchatDart {
   /// The user agent
   final VrchatUserAgent userAgent;