Skip to content

Commit 40958fc

Browse files
committed
Fix typings in service.tracing.tracingMiddlewares
Only handle errors if they are instances of Error. Otherwise, it wouldn't make sense to pass them along to ErrorReport.create()
1 parent 59a5452 commit 40958fc

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

src/service/tracing/tracingMiddlewares.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ export const addTracingMiddleware = (tracer: Tracer) => {
3838
try {
3939
await next()
4040
} catch (err) {
41+
if (!(err instanceof Error)) {
42+
throw err
43+
}
4144
ErrorReport.create({ originalError: err }).injectOnSpan(currentSpan, ctx.vtex?.logger)
4245
throw err
4346
} finally {
@@ -98,6 +101,9 @@ export const traceUserLandRemainingPipelineMiddleware = () => {
98101
span?.log({ event: RuntimeLogEvents.USER_MIDDLEWARES_START })
99102
await next()
100103
} catch (err) {
104+
if (!(err instanceof Error)) {
105+
throw err
106+
}
101107
ErrorReport.create({ originalError: err }).injectOnSpan(span, ctx.vtex.logger)
102108
throw err
103109
} finally {

0 commit comments

Comments
 (0)