Skip to content

Commit 2023375

Browse files
committed
fixed codeacy flagged issues
1 parent 5c05587 commit 2023375

1 file changed

Lines changed: 88 additions & 74 deletions

File tree

  • services/language_translation

services/language_translation/v2.js

Lines changed: 88 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,9 @@ module.exports = function (RED) {
7070
}
7171
lt.getModels({}, function (err, models) {
7272
if (err) {
73-
//console.log('Error:', err);
7473
res.json(err);
7574
}
7675
else {
77-
// console.log('Models are: ', models);
7876
res.json(models);
7977
}
8078
});
@@ -168,15 +166,15 @@ module.exports = function (RED) {
168166
params.name = msg.filename.replace(/[^0-9a-z]/gi, '');
169167
params.base_model_id = model_id;
170168
switch (filetype) {
171-
case 'forcedglossary':
172-
params.forced_glossary = fs.createReadStream(info.path);
173-
break;
169+
case 'forcedglossary':
170+
params.forced_glossary = fs.createReadStream(info.path);
171+
break;
174172
case 'parallelcorpus':
175-
params.parallel_corpus = fs.createReadStream(info.path);
176-
break;
173+
params.parallel_corpus = fs.createReadStream(info.path);
174+
break;
177175
case 'monolingualcorpus':
178-
params.monolingual_corpus = fs.createReadStream(info.path);
179-
break;
176+
params.monolingual_corpus = fs.createReadStream(info.path);
177+
break;
180178
}
181179

182180
language_translation.createModel(params,
@@ -296,6 +294,7 @@ module.exports = function (RED) {
296294
}
297295

298296
var action = msg.action || config.action;
297+
299298
if (!action) {
300299
node.warn('Missing action, please select one');
301300
node.send(msg);
@@ -306,71 +305,86 @@ module.exports = function (RED) {
306305
// are specific to the requested action.
307306
// The required fields are checked, before the relevant function is invoked.
308307
switch (action) {
309-
case 'translate':
310-
var domain = msg.domain || config.domain;
311-
312-
if (!domain) {
313-
node.warn('Missing translation domain, message not translated');
314-
node.send(msg);
315-
return;
316-
}
317-
var srclang = msg.srclang || config.srclang;
318-
if (!srclang) {
319-
node.warn('Missing source language, message not translated');
320-
node.send(msg);
321-
return;
322-
}
323-
var destlang = msg.destlang || config.destlang;
324-
if (!destlang) {
325-
node.warn('Missing target language, message not translated');
326-
node.send(msg);
327-
return;
328-
}
329-
var model_id = '';
330-
model_id = srclang + '-' + destlang;
331-
if (domain !== 'news') {
332-
model_id += ('-' + domain);
333-
}
334-
doTranslate(msg, model_id);
335-
break;
336-
case 'custom':
337-
var custom = msg.custom || config.custom;
338-
if (!custom) {
339-
node.warn('Missing customised model, message not translated');
340-
node.send(msg);
341-
return;
342-
}
343-
doTranslate(msg, custom);
344-
break;
345-
case 'train':
346-
var basemodel = msg.basemodel || config.basemodel;
347-
if (!basemodel) {
348-
node.warn('Base Model needs must be set for train mode');
349-
node.send(msg);
350-
}
351-
var filetype = msg.filetype || config.filetype;
352-
if (!filetype) {
353-
node.warn('Filetype needs must be set for train mode');
354-
node.send(msg);
355-
}
356-
doTrain(msg, basemodel, filetype);
357-
break;
358-
case 'getstatus':
359-
var trainid = msg.trainid || config.trainid;
360-
doGetStatus(msg, trainid);
361-
break;
362-
case 'delete':
363-
var d_trainid = msg.trainid || config.trainid;
364-
doDelete(msg, d_trainid);
365-
break;
366-
default:
367-
message = 'Unexpected Mode';
368-
node.status({
369-
fill: 'blue',
370-
shape: 'dot',
371-
text: message
372-
});
373-
node.error(message, msg);
308+
case 'translate':
309+
var domain = msg.domain || config.domain;
310+
311+
if (!domain) {
312+
node.warn('Missing translation domain, message not translated');
313+
node.send(msg);
314+
return;
315+
}
316+
317+
var srclang = msg.srclang || config.srclang;
318+
319+
if (!srclang) {
320+
node.warn('Missing source language, message not translated');
321+
node.send(msg);
322+
return;
323+
}
324+
325+
var destlang = msg.destlang || config.destlang;
326+
327+
if (!destlang) {
328+
node.warn('Missing target language, message not translated');
329+
node.send(msg);
330+
return;
331+
}
332+
333+
var model_id = '';
334+
335+
model_id = srclang + '-' + destlang;
336+
if (domain !== 'news') {
337+
model_id += ('-' + domain);
338+
}
339+
doTranslate(msg, model_id);
340+
break;
341+
342+
case 'custom':
343+
var custom = msg.custom || config.custom;
344+
345+
if (!custom) {
346+
node.warn('Missing customised model, message not translated');
347+
node.send(msg);
348+
return;
349+
}
350+
doTranslate(msg, custom);
351+
break;
352+
353+
case 'train':
354+
var basemodel = msg.basemodel || config.basemodel;
355+
356+
if (!basemodel) {
357+
node.warn('Base Model needs must be set for train mode');
358+
node.send(msg);
359+
}
360+
var filetype = msg.filetype || config.filetype;
361+
if (!filetype) {
362+
node.warn('Filetype needs must be set for train mode');
363+
node.send(msg);
364+
}
365+
doTrain(msg, basemodel, filetype);
366+
break;
367+
368+
case 'getstatus':
369+
var trainid = msg.trainid || config.trainid;
370+
371+
doGetStatus(msg, trainid);
372+
break;
373+
374+
case 'delete':
375+
var d_trainid = msg.trainid || config.trainid;
376+
377+
doDelete(msg, d_trainid);
378+
break;
379+
380+
default:
381+
message = 'Unexpected Mode';
382+
node.status({
383+
fill: 'blue',
384+
shape: 'dot',
385+
text: message
386+
});
387+
node.error(message, msg);
374388
}
375389
});
376390
}

0 commit comments

Comments
 (0)