Skip to content

Commit 3ddc181

Browse files
chughtschughts
committed
Codacy Fixes
1 parent dc20a3e commit 3ddc181

4 files changed

Lines changed: 75 additions & 75 deletions

File tree

‎services/assistant/v2.js‎

Lines changed: 49 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ module.exports = function(RED) {
5050
RED.nodes.createNode(this, config);
5151

5252
function setCredentials(msg) {
53-
creds = {
53+
var creds = {
5454
username : sUsername || node.credentials.username,
5555
password : sPassword || node.credentials.password || config.password,
5656
apikey : sApikey || node.credentials.apikey || config.apikey,
@@ -127,7 +127,7 @@ module.exports = function(RED) {
127127
params.context :
128128
{'skills' : {'main skill' : {'user_defined': {}}}};
129129

130-
for (prop in msg.additional_context) {
130+
for (var prop in msg.additional_context) {
131131
if (msg.additional_context.hasOwnProperty(prop)) {
132132
params.context.skills['main skill']['user_defined'][prop]
133133
= msg.additional_context[prop];
@@ -190,66 +190,66 @@ module.exports = function(RED) {
190190
}
191191

192192
function setServiceSettings(msg, creds) {
193-
const serviceSettings = {
193+
const serviceSettings = {
194194
headers: {
195195
'User-Agent': pkg.name + '-' + pkg.version
196196
}
197-
};
198-
let endpoint = '',
199-
optoutLearning = false,
200-
version = SERVICE_VERSION;
197+
};
198+
let endpoint = '',
199+
optoutLearning = false,
200+
version = SERVICE_VERSION;
201+
202+
if (creds.apikey) {
203+
serviceSettings.iam_apikey = creds.apikey;
204+
} else {
205+
serviceSettings.username = creds.username;
206+
serviceSettings.password = creds.password;
207+
}
201208

202-
if (creds.apikey) {
203-
serviceSettings.iam_apikey = creds.apikey;
204-
} else {
205-
serviceSettings.username = creds.username;
206-
serviceSettings.password = creds.password;
207-
}
209+
if (service) {
210+
endpoint = service.url;
211+
}
212+
if (!config['default-endpoint'] && config['service-endpoint']) {
213+
endpoint = config['service-endpoint'];
214+
}
208215

209-
if (service) {
210-
endpoint = service.url;
216+
if (config['optout-learning']){
217+
optoutLearning = true;
218+
}
219+
220+
if (config['timeout'] && config['timeout'] !== '0' && isFinite(config['timeout'])){
221+
serviceSettings.timeout = parseInt(config['timeout']);
222+
}
223+
224+
// Look for message overrides
225+
if (msg.params) {
226+
if (msg.params.endpoint) {
227+
endpoint = msg.params.endpoint;
211228
}
212-
if (!config['default-endpoint'] && config['service-endpoint']) {
213-
endpoint = config['service-endpoint'];
229+
if (msg.params.version) {
230+
version = msg.params.version;
214231
}
215-
216-
if (config['optout-learning']){
232+
if ((msg.params['optout_learning'])){
217233
optoutLearning = true;
218234
}
219-
220-
if (config['timeout'] && config['timeout'] !== '0' && isFinite(config['timeout'])){
221-
serviceSettings.timeout = parseInt(config['timeout']);
235+
if (msg.params.timeout !== '0' && isFinite(msg.params.timeout)){
236+
serviceSettings.timeout = parseInt(msg.params.timeout);
222237
}
223-
224-
// Look for message overrides
225-
if (msg.params) {
226-
if (msg.params.endpoint) {
227-
endpoint = msg.params.endpoint;
228-
}
229-
if (msg.params.version) {
230-
version = msg.params.version;
231-
}
232-
if ((msg.params['optout_learning'])){
233-
optoutLearning = true;
234-
}
235-
if (msg.params.timeout !== '0' && isFinite(msg.params.timeout)){
236-
serviceSettings.timeout = parseInt(msg.params.timeout);
237-
}
238-
if (msg.params.disable_ssl_verification){
239-
serviceSettings.disable_ssl_verification = true;
240-
}
238+
if (msg.params.disable_ssl_verification){
239+
serviceSettings.disable_ssl_verification = true;
241240
}
241+
}
242242

243-
serviceSettings.version = version;
244-
if (endpoint) {
245-
serviceSettings.url = endpoint;
246-
}
247-
if (optoutLearning) {
248-
serviceSettings.headers = serviceSettings.headers || {};
249-
serviceSettings.headers['X-Watson-Learning-Opt-Out'] = '1';
250-
}
243+
serviceSettings.version = version;
244+
if (endpoint) {
245+
serviceSettings.url = endpoint;
246+
}
247+
if (optoutLearning) {
248+
serviceSettings.headers = serviceSettings.headers || {};
249+
serviceSettings.headers['X-Watson-Learning-Opt-Out'] = '1';
250+
}
251251

252-
return Promise.resolve(serviceSettings);
252+
return Promise.resolve(serviceSettings);
253253
}
254254

255255
function buildService(settings) {

‎services/language_translator/v3-doc.js‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
**/
1616

1717
module.exports = function (RED) {
18-
const request = require('request');
18+
const request = require('request'),
1919
SERVICE_IDENTIFIER = 'language-translator',
2020
SERVICE_VERSION = '2018-05-01';
2121

@@ -121,7 +121,7 @@ module.exports = function (RED) {
121121
case 'getDocument':
122122
case 'translateSubmittedDocument':
123123
if (!docID(msg)) {
124-
message = 'Document ID is required';
124+
message = 'Document ID is required';
125125
}
126126
break;
127127
default:
@@ -147,7 +147,6 @@ module.exports = function (RED) {
147147
}
148148

149149
function executeRequest(uriAddress, method) {
150-
console.log('uri is ', uriAddress);
151150
return new Promise(function resolver(resolve, reject){
152151
var authSettings = buildAuthSettings();
153152

@@ -160,24 +159,25 @@ module.exports = function (RED) {
160159
reject(error);
161160
} else {
162161
switch (response.statusCode) {
163-
case 200:
164-
let data = null;
165-
try {
166-
data = JSON.parse(body);
167-
} catch(e) {
168-
data = body
169-
}
170-
resolve(data);
171-
break;
172-
case 204:
173-
resolve(body);
174-
break;
175-
case 404:
176-
reject('Document not found ' + response.statusCode);
177-
default:
178-
console.log(body);
179-
reject('Error Invoking API ' + response.statusCode);
180-
break;
162+
case 200:
163+
let data = null;
164+
try {
165+
data = JSON.parse(body);
166+
} catch(e) {
167+
data = body
168+
}
169+
resolve(data);
170+
break;
171+
case 204:
172+
resolve(body);
173+
break;
174+
case 404:
175+
reject('Document not found ' + response.statusCode);
176+
break;
177+
default:
178+
console.log(body);
179+
reject('Error Invoking API ' + response.statusCode);
180+
break;
181181
}
182182
}
183183
});

‎services/speech_to_text/v1.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -343,10 +343,10 @@ module.exports = function (RED) {
343343
// Check for keywords, which might already be an array
344344
if (config['keywords'] && 'string' === typeof config['keywords']) {
345345
// Trim any [] from edges of string
346-
var keywords = config['keywords'];
347-
var start = 0;
348-
var end = keywords.length;
349-
var threshold = parseFloat(config['keywords_threshold']);
346+
var keywords = config['keywords'],
347+
start = 0,
348+
end = keywords.length,
349+
threshold = parseFloat(config['keywords_threshold']);
350350

351351
if ('[' === keywords[start]) {
352352
start++;

‎utilities/payload-utils.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ PayloadUtils.prototype = {
168168
if (ct === 'ja') {
169169
fn = function(txt, cb) {
170170
cb(200);
171-
}
171+
};
172172
} else if (ct === 'ko') {
173173
fn = function(txt, cb) {
174174
cb(count(txt));

0 commit comments

Comments
 (0)