Skip to content

Commit 7925eaf

Browse files
committed
renaming methods to use snake case, fixing test case
1 parent 32c544f commit 7925eaf

2 files changed

Lines changed: 12 additions & 9 deletions

File tree

test/test_natural_language_understanding.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,26 +124,27 @@ def test_url_analyze(self):
124124
assert len(responses.calls) == 1
125125

126126
@responses.activate
127-
def test_listModels(self):
127+
def test_list_models(self):
128128
nlu_url = "http://bogus.com/v1/models"
129-
responses.add(responses.GET, nlu_url, status=200, body="{\"resulting_key\": true}",
129+
responses.add(responses.GET, nlu_url, status=200,
130+
body="{\"resulting_key\": true}",
130131
content_type='application/json')
131132
nlu = NaturalLanguageUnderstandingV1(version='2016-01-23',
132133
url='http://bogus.com',
133134
username='username',
134135
password='password')
135-
nlu.listModels();
136+
nlu.list_models()
136137
assert len(responses.calls) == 1
137138

138139
@responses.activate
139-
def test_deleteModel(self):
140+
def test_delete_model(self):
140141
model_id = "invalid_model_id"
141142
nlu_url = "http://bogus.com/v1/models/" + model_id
142143
responses.add(responses.DELETE, nlu_url, status=200,
143-
content_type='application/json')
144+
body="{}", content_type='application/json')
144145
nlu = NaturalLanguageUnderstandingV1(version='2016-01-23',
145146
url='http://bogus.com',
146147
username='username',
147148
password='password')
148-
nlu.deleteModel(model_id);
149+
nlu.delete_model(model_id)
149150
assert len(responses.calls) == 1

watson_developer_cloud/natural_language_understanding_v1.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ def analyze(self, features, text=None, url=None, html=None,
8282
headers={'content-type': 'application/json'},
8383
json=body,
8484
accept_json=True)
85-
def listModels(self):
85+
86+
def list_models(self):
8687
"""
8788
Lists the custom models available for your service instance
8889
:return: dict of available custom models
@@ -91,13 +92,14 @@ def listModels(self):
9192
params={"version": self.version},
9293
accept_json=True)
9394

94-
def deleteModel(self, model_id):
95+
def delete_model(self, model_id):
9596
"""
9697
Deletes a custom model
9798
:param model_id: The ID of the model to delete
9899
:return: dict with status of model deletion
99100
"""
100101

101-
return self.request(method='DELETE', url='/v1/models/{0}'.format(model_id),
102+
return self.request(method='DELETE',
103+
url='/v1/models/{0}'.format(model_id),
102104
params={"version": self.version},
103105
accept_json=True)

0 commit comments

Comments
 (0)