clippy

Author: deadblackclover

src/account.rs

@@ -48,14 +48,14 @@ pub(crate) fn sign(message: &[u8], secret_key: &[u8; SECRET_KEY_LENGTH]) -> [u8;
         .compress()
         .to_bytes();
 
-    let ed_pubkey = &constants::ED25519_BASEPOINT_POINT * &Scalar::from_bits(*secret_key);
+    let ed_pubkey = constants::ED25519_BASEPOINT_POINT * Scalar::from_bits(*secret_key);
     let pubkey = ed_pubkey.compress().to_bytes();
 
     hash = Sha512::default();
     hash.input(&r);
     hash.input(&pubkey);
     hash.input(message);
-    let s = &(&Scalar::from_hash(hash) * &Scalar::from_bits(*secret_key)) + &rsc;
+    let s = (Scalar::from_hash(hash) * Scalar::from_bits(*secret_key)) + rsc;
 
     let sign = pubkey[31] & 0x80;
     let mut result = [0; SIGNATURE_LENGTH];

src/bytebuffer.rs

@@ -10,6 +10,7 @@ impl Buffer {
         Buffer { buf: Vec::new() }
     }
 
+    #[allow(dead_code)]
     pub fn from_bytes(b: &[u8]) -> Buffer {
         Buffer { buf: Vec::from(b) }
     }
@@ -55,9 +56,9 @@ impl Buffer {
             self.byte(0x02)
                 .byte(chain_id)
                 .size(recipient.len())
-                .bytes(&recipient.as_bytes())
+                .bytes(recipient.as_bytes())
         } else {
-            self.bytes(&recipient.from_base58().unwrap().as_slice())
+            self.bytes(recipient.from_base58().unwrap().as_slice())
         }
     }
 

src/transaction.rs

@@ -41,6 +41,7 @@ pub struct Transaction<'a> {
 use transaction_data::TransactionData::*;
 
 impl<'a> Transaction<'a> {
+    #[allow(clippy::too_many_arguments)]
     pub fn new_issue(
         sender_public_key: &'a PublicKeyAccount,
         name: &'a str,
@@ -71,6 +72,7 @@ impl<'a> Transaction<'a> {
         }
     }
 
+    #[allow(clippy::too_many_arguments)]
     pub fn new_transfer(
         sender_public_key: &'a PublicKeyAccount,
         recipient: &'a Address,
@@ -328,8 +330,8 @@ impl<'a> Transaction<'a> {
                 attachment,
             } => buf
                 .bytes(self.sender_public_key.to_bytes())
-                .asset_opt(&asset)
-                .asset_opt(&fee_asset)
+                .asset_opt(asset)
+                .asset_opt(fee_asset)
                 .long(self.timestamp)
                 .long(amount)
                 .long(self.fee)
@@ -343,7 +345,7 @@ impl<'a> Transaction<'a> {
             } => buf
                 .byte(chain_id)
                 .bytes(self.sender_public_key.to_bytes())
-                .asset(&asset)
+                .asset(asset)
                 .long(quantity)
                 .boolean(reissuable)
                 .long(self.fee)
@@ -355,7 +357,7 @@ impl<'a> Transaction<'a> {
             } => buf
                 .byte(chain_id)
                 .bytes(self.sender_public_key.to_bytes())
-                .asset(&asset)
+                .asset(asset)
                 .long(quantity)
                 .long(self.fee)
                 .long(self.timestamp),
@@ -390,7 +392,7 @@ impl<'a> Transaction<'a> {
                 attachment,
             } => {
                 buf.bytes(self.sender_public_key.to_bytes())
-                    .asset_opt(&asset)
+                    .asset_opt(asset)
                     .size(transfers.len());
                 for (addr, amt) in transfers {
                     buf.bytes(addr.to_bytes()).long(*amt);