fix(email): refacto try catch and log

Author: kevin-blackbird

src/Command/AlertCommand.php

@@ -45,32 +45,33 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         //I think that this load in the long time can be a bottle necklace
         $subscriptions = $this->backInStockNotificationRepository->findBy(['notify' => false]);
         foreach ($subscriptions as $subscription) {
-            try {
-                $channel = $subscription->getChannel();
-                $productVariant = $subscription->getProductVariant();
-                if ($productVariant === null || $channel === null) {
-                    $this->backInStockNotificationRepository->remove($subscription);
-                    $this->logger->warning(
-                        'The back in stock subscription for the product does not have all the information required',
-                        ['subscription' => var_export($subscription, true)],
-                    );
+            $channel        = $subscription->getChannel();
+            $productVariant = $subscription->getProductVariant();
+            if ($productVariant === null || $channel === null) {
+                $this->backInStockNotificationRepository->remove($subscription);
+                $this->logger->warning(
+                    'The back in stock subscription for the product does not have all the information required',
+                    ['subscription' => var_export($subscription, true)],
+                );
 
-                    continue;
-                }
+                continue;
+            }
 
-                if (
-                    $this->availabilityChecker->isStockAvailable($productVariant) &&
-                    $productVariant->isEnabled() &&
-                    $productVariant->getProduct()?->isEnabled() === true
-                ) {
-                    $this->router->getContext()->setHost($channel->getHostname() ?? 'localhost');
+            if (
+                $this->availabilityChecker->isStockAvailable($productVariant) &&
+                $productVariant->isEnabled() &&
+                $productVariant->getProduct()?->isEnabled() === true
+            ) {
+                $this->router->getContext()->setHost($channel->getHostname() ?? 'localhost');
+
+                try {
                     $this->sendEmail($subscription, $productVariant, $channel);
-                    $subscription->setNotify(true);
-                    $this->backInStockNotificationRepository->add($subscription);
+                } catch (RfcComplianceException $e) {
+                    $this->logger->warning('Invalid email address, continue to the next one: ' . $e->getMessage());
+                    continue;
                 }
-            } catch (RfcComplianceException $e) {
-                // Invalid email address, continue to the next one
-                $this->logger->warning($e->getMessage());
+                $subscription->setNotify(true);
+                $this->backInStockNotificationRepository->add($subscription);
             }
         }