Idempotent migrations

Author: LucaGallinari

UPGRADE.md

@@ -1,6 +1,15 @@
 # Upgrade plugin guide
 
-## Upgrade from version 1.x to 2.x
+## Upgrade from version v0.x to v1.x
+
+The v2 is now compatible with Sylius 2.x, so you need to update your Sylius version to 2.x before upgrading the plugin. Some changes not listed here may be required, so please refer to the Sylius 2.x upgrade guide for more details.
+
+- The route `@WebgriffeSyliusTableRateShippingPlugin/Resources/config/config.yml` has been renamed to `@WebgriffeSyliusTableRateShippingPlugin/config/config.yaml`.
+- The route `@WebgriffeSyliusTableRateShippingPlugin/Resources/config/admin_routing.yml` has been renamed to `@WebgriffeSyliusTableRateShippingPlugin/config/routes/admin.yaml`.
+- The route `webgriffe_sylius_table_rate_shipping_plugin_shop` has been removed as it was unnecessary
+- The migrations are now stored inside the plugin in `src/Migrations`. These should be idempotent, so if the changes made by these migrations are already present, they will do nothing.
+
+## Upgrade from version v1.x to v2.x
 
 - The service `app.taxation.italian_tax_calculation_strategy` has been renamed to `webgriffe_sylius_italian_invoiceable_order.strategy.taxation.tax_calculation.italian_tax_calculation_strategy`.
 - The class `Webgriffe\SyliusItalianInvoiceableOrderPlugin\Model\ItalianTaxCalculationStrategy` has been moved to `Webgriffe\SyliusItalianInvoiceableOrderPlugin\Taxation\ItalianTaxCalculationStrategy`.

src/Migrations/Version20260109151240.php

@@ -15,12 +15,52 @@ final class Version20260109151240 extends AbstractMigration
     #[\Override]
     public function up(Schema $schema): void
     {
-        $this->addSql('ALTER TABLE sylius_address ADD billing_recipient_type VARCHAR(255) DEFAULT NULL, ADD tax_code VARCHAR(255) DEFAULT NULL, ADD vat_number VARCHAR(255) DEFAULT NULL, ADD sdi_code VARCHAR(255) DEFAULT NULL, ADD pec_address VARCHAR(255) DEFAULT NULL');
+        $table = $schema->getTable('sylius_address');
+
+        if (!$table->hasColumn('billing_recipient_type')) {
+            $this->addSql('ALTER TABLE sylius_address ADD billing_recipient_type VARCHAR(255) DEFAULT NULL');
+        }
+
+        if (!$table->hasColumn('tax_code')) {
+            $this->addSql('ALTER TABLE sylius_address ADD tax_code VARCHAR(255) DEFAULT NULL');
+        }
+
+        if (!$table->hasColumn('vat_number')) {
+            $this->addSql('ALTER TABLE sylius_address ADD vat_number VARCHAR(255) DEFAULT NULL');
+        }
+
+        if (!$table->hasColumn('sdi_code')) {
+            $this->addSql('ALTER TABLE sylius_address ADD sdi_code VARCHAR(255) DEFAULT NULL');
+        }
+
+        if (!$table->hasColumn('pec_address')) {
+            $this->addSql('ALTER TABLE sylius_address ADD pec_address VARCHAR(255) DEFAULT NULL');
+        }
     }
 
     #[\Override]
     public function down(Schema $schema): void
     {
-        $this->addSql('ALTER TABLE sylius_address DROP billing_recipient_type, DROP tax_code, DROP vat_number, DROP sdi_code, DROP pec_address');
+        $table = $schema->getTable('sylius_address');
+
+        if ($table->hasColumn('pec_address')) {
+            $this->addSql('ALTER TABLE sylius_address DROP pec_address');
+        }
+
+        if ($table->hasColumn('sdi_code')) {
+            $this->addSql('ALTER TABLE sylius_address DROP sdi_code');
+        }
+
+        if ($table->hasColumn('vat_number')) {
+            $this->addSql('ALTER TABLE sylius_address DROP vat_number');
+        }
+
+        if ($table->hasColumn('tax_code')) {
+            $this->addSql('ALTER TABLE sylius_address DROP tax_code');
+        }
+
+        if ($table->hasColumn('billing_recipient_type')) {
+            $this->addSql('ALTER TABLE sylius_address DROP billing_recipient_type');
+        }
     }
 }