ci: optimize and fix documentation upload workflow

- Replace slow `cargo install` of mdbook and mdbook-linkcheck with direct binary downloads.

- Upgrade `actions/checkout` from v2 to v4.

- Do robust preparational steps and only let the last step perform a final rsync

- remove some boilerplate comments

Author: hpk42

.github/workflows/upload-main.yml

@@ -1,50 +1,51 @@
-# workflow for rendering and uploads webxdc docs 
+# workflow for rendering and uploads webxdc docs
 
-name: Render and upload webxdc docs 
+name: Render and upload webxdc docs
 
-# Controls when the workflow will run
 on:
-  # Triggers the workflow on push or pull request events but only for the master branch
   push:
-    branches: 
+    branches:
       - main
-
-  # Allows you to run this workflow manually from the Actions tab
   workflow_dispatch:
 
-# A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
-  # This workflow contains a single job called "build"
   build:
-    # The type of runner that the job will run on
     runs-on: ubuntu-latest
 
-    # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-      - uses: actions/checkout@v2
+      - name: Checkout code
+        uses: actions/checkout@v4
 
-      - uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
+      - name: Setup mdBook
+        run: |
+          MDBOOK_VERSION="0.4.40"
+          curl -sSL "https://github.com/rust-lang/mdBook/releases/download/v${MDBOOK_VERSION}/mdbook-v${MDBOOK_VERSION}-x86_64-unknown-linux-gnu.tar.gz" | tar -xz
+          sudo mv mdbook /usr/local/bin/
 
-      - name: Rust Cache
-        uses: Swatinem/rust-cache@v1.3.0
+      - name: Install mdbook-linkcheck
+        run: |
+          curl -sSL "https://github.com/Michael-F-Bryan/mdbook-linkcheck/releases/latest/download/mdbook-linkcheck.x86_64-unknown-linux-gnu.zip" -o mdbook-linkcheck.zip
+          unzip mdbook-linkcheck.zip mdbook-linkcheck
+          chmod +x mdbook-linkcheck
+          sudo mv mdbook-linkcheck /usr/local/bin/
 
-      - name: install mdbook
+      - name: Build docs
         run: |
-          cargo install mdbook --vers "^0.4"
-          cargo install mdbook-linkcheck
-          cd src-docs 
+          cd src-docs
           mdbook build
-          mv book/html ../website/docs
+          mkdir -p ../website/docs
+          cp -r book/html/* ../website/docs/
+
+      - name: Prepare website and apps
+        run: |
+          # Ensure website/apps exists and copy contents
+          mkdir -p website/apps
+          cp -r apps/* website/apps/
 
-      - name: Upload website including docs and apps 
+      - name: Upload website including docs and apps
         run: |
           mkdir -p "$HOME/.ssh"
           echo "${{ secrets.KEY }}" > "$HOME/.ssh/key"
           chmod 600 "$HOME/.ssh/key"
-          mv apps website/
-          rsync -avzh -e "ssh -i $HOME/.ssh/key -o StrictHostKeyChecking=no" "website/" "${{ secrets.USERNAME }}@delta.chat:/var/www/html/webxdc.org" 
+          # Rsync using the correct source and target
+          rsync -avzh -e "ssh -i $HOME/.ssh/key -o StrictHostKeyChecking=no" "website/" "${{ secrets.USERNAME }}@delta.chat:/var/www/html/webxdc.org"