#44: adding tests for github actions

Author: rafaelfsilva

tests/unit/test_workflow.py

@@ -8,13 +8,15 @@
 # the Free Software Foundation, either version 3 of the License, or
 # (at your option) any later version.
 
+import pathlib
 import pytest
 
 from wfcommons.common import Task, Workflow
 from wfcommons.version import __version__, __schema_version__
 
 
 tasks_list = [
+    ([Task(name="task_1", task_id="task_1", runtime=15.0)]),
     ([Task(name="task_1", task_id="task_1", runtime=15.0), Task(name="task_2", task_id="task_2", runtime=30.0)]),
     ([Task(name="task_1", task_id="task_1", runtime=15.0), Task(name="task_2", task_id="task_2", runtime=30.0), Task(name="task_3", task_id="task_3", runtime=60.0)]),
 ]
@@ -31,7 +33,7 @@ def workflow(self) -> Workflow:
 
     @pytest.mark.unit
     def test_workflow_creation(self, workflow: Workflow) -> None:
-        workflow.write_json("/tmp/workflow_test.json")
+        workflow.write_json(pathlib.Path("/tmp/workflow_test.json"))
 
         workflow_json = {
             "name": "Workflow Test",
@@ -95,4 +97,15 @@ def test_workflow_add_dependencies_leaves(self, workflow: Workflow, tasks: list[
             if previous_task:
                 workflow.add_dependency(previous_task.task_id, task.task_id)
             previous_task = task
-        assert(workflow.leaves() == [previous_task.task_id])
+        assert(workflow.leaves() == [previous_task.task_id])
+
+    @pytest.mark.unit
+    def test_dot(self, workflow: Workflow) -> None:
+        dot_file_path = pathlib.Path("/tmp/workflow_test.dot")
+        workflow.add_task(Task(name="task_1", task_id="task_1", runtime=15.0))
+        workflow.add_task(Task(name="task_2", task_id="task_2", runtime=30.0))
+        workflow.add_dependency("task_1", "task_2")
+        workflow.write_dot(dot_file_path)
+        dot_workflow = Workflow("workflow")
+        dot_workflow.read_dot(dot_file_path)
+        # assert(workflow == dot_workflow)

wfcommons/common/task.py

@@ -174,3 +174,6 @@ def execution_as_dict(self) -> Dict:
         if self.launch_dir:
             task_obj['launchDir'] = self.launch_dir
         return task_obj
+
+    def __str__(self) -> str:
+        return self.task_id

wfcommons/common/workflow.py

@@ -94,7 +94,7 @@ def add_task(self, task: Task) -> None:
         self.tasks[task.task_id] = task
         self.tasks_parents.setdefault(task.task_id, set())
         self.tasks_children.setdefault(task.task_id, set())
-        self.add_node(task.task_id, task=task)
+        self.add_node(task.task_id, task=task, label=task.task_id)
 
     def add_dependency(self, parent: str, child: str) -> None:
         """