Skip to content

Commit 4c735dd

Browse files
committed
Text fixes
1 parent 55c1aa1 commit 4c735dd

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/build.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ jobs:
3434
3535
- name: Check package install
3636
run: |
37-
sudo sed -i 's|if os.path.exists(cpu_benchmark_path):|if True:|' ./setup.py
3837
pip install .
3938
4039
- name: Run tests

tests/test_helpers.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ def _install_WfCommons_on_container(container):
4747
stderr=True)
4848
exit_code, output = container.exec_run("sudo /bin/rm -rf /tmp/WfCommons/bin/cpu-benchmark", stdout=True,
4949
stderr=True)
50-
exit_code, output = container.exec_run(r"sudo sed -i 's|if os.path.exists(cpu_benchmark_path):|if True:|' /tmp/WfCommons/setup.py")
5150

5251
# Install WfCommons on the container (to install wfbench and cpu-benchmark really)
5352
exit_code, output = container.exec_run("sudo python3 -m pip install . --break-system-packages",

tests/translators_loggers/test_translators_loggers.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,11 @@ def test_translator(self, backend) -> None:
259259
translator = translator_classes[backend](benchmark.workflow)
260260
translator.translate(output_folder=dirpath)
261261

262-
# Make the directory that holds the translation world-writable,
263-
# so that docker commands won't fail
264-
os.chmod(dirpath, 0o777)
262+
# # Make the directory that holds the translation world-writable,
263+
# # so that docker commands won't fail
264+
# TODO: Explore whether this below makes tests runnable on Linux due to
265+
# different Docker permission schemes, etc.
266+
# os.chmod(dirpath, 0o777)
265267

266268
# Start the Docker container
267269
container = _start_docker_container(backend, str_dirpath, str_dirpath, str_dirpath + "bin/")

0 commit comments

Comments
 (0)