Skip to content

Commit 6f850c2

Browse files
committed
Testing cleanup
Performing docker image removal only if running on CI
1 parent 2c790ff commit 6f850c2

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

tests/test_helpers.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -101,18 +101,19 @@ def _start_docker_container(backend, mounted_dir, working_dir, bin_dir, command=
101101
def _shutdown_docker_container_and_remove_image(container):
102102
image = container.image
103103
sys.stderr.write(f"[{container.backend}] Terminating container if need be...\n")
104-
sys.stderr.write("CONTAINER IS = " + str(container.id) + "\n")
105104
try:
106105
container.stop()
107106
container.remove()
108107
except Exception as e:
109-
sys.stderr.write("GOT AN EXCEPTION FOR CONTAINER STOP/REMOVE... WHATEVER\n")
110-
111-
sys.stderr.write(f"[{container.backend}] Removing Docker image...\n")
112-
try:
113-
image.remove(force=True)
114-
except Exception as e:
115-
sys.stderr.write(f"[{container.backend}] Warning: Error while removing image: {e}\n")
108+
pass
109+
110+
# Remove the images as we go, if running on GitHub
111+
if os.getenv('CI') or os.getenv('GITHUB_ACTIONS'):
112+
sys.stderr.write(f"[{container.backend}] Removing Docker image...\n")
113+
try:
114+
image.remove(force=True)
115+
except Exception as e:
116+
sys.stderr.write(f"[{container.backend}] Warning: Error while removing image: {e}\n")
116117

117118
def _get_total_size_of_directory(directory_path: str):
118119
total_size = 0

0 commit comments

Comments
 (0)