Skip to content

Commit d5090cf

Browse files
committed
Updated the taskvine translator to take in the vine-logs directory
1 parent 60ca14e commit d5090cf

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

tests/translators_loggers/test_translators_loggers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ def test_translator(self, backend) -> None:
280280
if backend == "pegasus":
281281
parser = PegasusLogsParser(dirpath / "work/wfcommons/pegasus/Blast-Benchmark/run0001/")
282282
elif backend == "taskvine":
283-
parser = TaskVineLogsParser(dirpath / "vine-run-info/", filenames_to_ignore=["cpu-benchmark","stress-ng", "wfbench"])
283+
parser = TaskVineLogsParser(dirpath / "vine-run-info/most-recent/vine-logs", filenames_to_ignore=["cpu-benchmark","stress-ng", "wfbench"])
284284
else:
285285
parser = None
286286

wfcommons/wfinstances/logs/taskvine.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ class TaskVineLogsParser(LogsParser):
3434
the exact same input/output files. There is likely a way to address this, but it hasn't been done yet.
3535
For instance, the Gutenberg TaskVine example isn't parsed correctly by this parser due to the above feature.
3636
37-
:param vine_run_info_dir: TaskVine's vine-run-info directory.
38-
:type vine_run_info_dir: pathlib.Path
37+
:param vine_logs_dir: TaskVine's vine-logs directory
38+
:type vine_logs_dir: pathlib.Path
3939
:param filenames_to_ignore: TaskVine sometimes considers that executables and package files
4040
are input to tasks. This argument is the list of names of files that should be
4141
ignored in the reconstructed instances, which typically do not include such
@@ -48,24 +48,24 @@ class TaskVineLogsParser(LogsParser):
4848
:type logger: Optional[Logger]
4949
"""
5050
def __init__(self,
51-
vine_run_info_dir: pathlib.Path,
51+
vine_logs_dir: pathlib.Path,
5252
filenames_to_ignore: Optional[List[str]] = None,
5353
description: Optional[str] = None,
5454
logger: Optional[Logger] = None) -> None:
5555
"""Create an object of the makeflow log parser."""
5656
super().__init__('TaskVine', 'http://https://ccl.cse.nd.edu/software/taskvine/', description, logger)
5757

5858
# Sanity check
59-
if not vine_run_info_dir.is_dir():
60-
raise OSError(f'The provided path does not exist or is not a folder: {vine_run_info_dir}')
59+
if not vine_logs_dir.is_dir():
60+
raise OSError(f'The provided path does not exist or is not a folder: {vine_logs_dir}')
6161

62-
debug_file: pathlib.Path = vine_run_info_dir / "most-recent/vine-logs/debug"
62+
debug_file: pathlib.Path = vine_logs_dir / "debug"
6363
if not debug_file.is_file():
6464
raise OSError(f'Cannot find file: {debug_file}')
65-
taskgraph_file: pathlib.Path = vine_run_info_dir / "most-recent/vine-logs/taskgraph"
65+
taskgraph_file: pathlib.Path = vine_logs_dir / "taskgraph"
6666
if not taskgraph_file.is_file():
6767
raise OSError(f'Cannot find file: {taskgraph_file}')
68-
transactions_file: pathlib.Path = vine_run_info_dir / "most-recent/vine-logs/transactions"
68+
transactions_file: pathlib.Path = vine_logs_dir / "transactions"
6969
if not transactions_file.is_file():
7070
raise OSError(f'Cannot find file: {transactions_file}')
7171

0 commit comments

Comments
 (0)