check binary exists + more logging

Author: dem1fo

src/crypto/gpg.ts

@@ -87,40 +87,62 @@ export class GpgWrapper {
   }
 
   public async encryptFile({ inputPath, outputPath, recipient, signer, signerPassphrase }: EncryptFileInput): Promise<EncryptFileResult> {
+    // TODO: move this into the constructor?
+    try {
+      log(`[DEBUG] Checking GPG binary at path: '${this.binPath}'`);
+      await access(this.binPath, constants.X_OK);
+      log(`[DEBUG] GPG binary is executable.`);
+    }
+    catch {
+      log(`[ERROR] GPG binary not found or not executable at path: '${this.binPath}'`);
+      return { success: false, error: `GPG binary not found or not executable at path: '${this.binPath}'`, code: GpgErrorCode.GPG_NOT_FOUND }
+    }
 
     // check read permissions on input
-    try { await access(inputPath, constants.R_OK) }
+    try {
+      log(`[DEBUG] Checking read access for input file at path: '${inputPath}'`);
+      await access(inputPath, constants.R_OK);
+      log(`[DEBUG] Read access confirmed for input file.`);
+    }
     catch {
       log(`[ERROR] Unable to read input file, insufficient permissions for path: '${inputPath}'`);
       return { success: false, error: `Unable to read input file: '${inputPath}'`, code: "INPUT_NOT_READABLE" }
     }
 
     // check write permissions on output
     const outputDir = dirname(outputPath);
-    try { await access(outputDir, constants.W_OK) }
+    try {
+      log(`[DEBUG] Checking write access for output directory at path: '${outputDir}'`);
+      await access(outputDir, constants.W_OK);
+      log(`[DEBUG] Write access confirmed for output directory.`);
+    }
     catch {
       log(`[ERROR] Unable to write to output directory, insufficient permissions for path: '${outputDir}'`);
       return { success: false, error: `Unable to write to output path: '${outputPath}'`, code: "OUTPUT_NOT_WRITABLE" }
     }
 
     // check recipient key is in keyring and valid
     if (this.options.verifyRecipientKey) {
+      log(`[DEBUG] Verifying recipient key exists in keyring: '${recipient}'`);
       const okay = this.keyExists(recipient, "RECIPIENT");
       if (!okay) {
         const msg = `Recipient key not found in local keyring: '${recipient}'`;
         log(`[ERROR] ${msg}`);
         return { success: false, error: msg, code: GpgErrorCode.RECIPIENT_KEY_NOT_FOUND }
       }
+      log(`[DEBUG] Recipient key exists in keyring.`);
     }
 
     // check signer key is in the keyring and valid
     if (signer && this.options.verifySignerKey) {
+      log(`[DEBUG] Verifying signer secret key exists in keyring: '${signer}'`);
       const okay = this.keyExists(signer, "SIGNER");
       if (!okay) {
         const msg = `Signer secret key not found in local keyring: '${signer}'`
         log(`[ERROR] ${msg}`);
         return { success: false, error: msg, code: GpgErrorCode.SIGNER_KEY_NOT_FOUND }
       }
+      log(`[DEBUG] Signer secret key exists in keyring.`);
     }
 
     // https://www.gnupg.org/documentation/manuals/gnupg/GPG-Configuration-Options.html
@@ -156,7 +178,7 @@ export class GpgWrapper {
     const result = spawnSync(this.binPath, finalArgs, {
       stdio: ['pipe', 'pipe', 'pipe'],
       env: { ...process.env },
-      timeout: this.options.timeoutMs ?? 30_000,
+      timeout: this.options.timeoutMs ?? 60_000,
       encoding: "utf-8",
       input: inputData
     });

src/crypto/gpgError.ts

@@ -1,4 +1,5 @@
 export enum GpgErrorCode {
+  GPG_NOT_FOUND = "GPG_NOT_FOUND",
   RECIPIENT_KEY_NOT_FOUND = "RECIPIENT_KEY_NOT_FOUND",
   RECIPIENT_KEY_REVOKED = "RECIPIENT_KEY_REVOKED",
   RECIPIENT_KEY_EXPIRED = "RECIPIENT_KEY_EXPIRED",
@@ -83,6 +84,11 @@ export const GpgErrorMap: Record<GpgErrorCode, GpgErrorDetail> = {
     message: 'An unexpected GPG error occurred.'
   },
 
+  [GpgErrorCode.GPG_NOT_FOUND]: {
+    code: GpgErrorCode.GPG_NOT_FOUND,
+    regex: /gpg:\s+.*not found/i, // TODO: this probably won't work
+    message: 'The GPG binary was not found or is not executable.'
+  },
 }
 
 export function identifyError(stderrRaw: string): GpgErrorDetail {