bubble up error messages

Author: dem1fo

src/processing/postprocess.ts

@@ -24,15 +24,22 @@ const enum POSTPROCESSING_STEP {
   ENCRYPTION = 'ENCRYPTION',
 }
 
-type Step = {
-  success: boolean;
+type StepPassed = {
+  success: true;
   step: POSTPROCESSING_STEP;
   outputPath?: string;
 };
 
+type StepFailed = {
+  success: false;
+  step: POSTPROCESSING_STEP;
+  error: string;
+};
+
+
 export interface PostprocessFileResult {
   success: boolean;
-  steps: Step[];
+  steps: (StepPassed | StepFailed)[];
   outputPath?: string;
 }
 
@@ -75,7 +82,7 @@ export async function postprocessFile({ config, inputPath, outputPath, options }
 
     if (!encryptResult.success) {
       log(`[ERROR] Encryption failed: ${encryptResult.error} (code: ${encryptResult.code})`);
-      result.steps.push({ success: false, step: POSTPROCESSING_STEP.ENCRYPTION });
+      result.steps.push({ success: false, step: POSTPROCESSING_STEP.ENCRYPTION, error: encryptResult.error });
     }
     else result.steps.push({ success: true, step: POSTPROCESSING_STEP.ENCRYPTION, outputPath: encryptResult.outputPath });
   }
@@ -84,6 +91,11 @@ export async function postprocessFile({ config, inputPath, outputPath, options }
 
   log("[INFO] Postprocessing complete.");
   if (result.steps.some(s => !s.success)) result.success = false;
-  else if (result.steps.length > 0) result.outputPath = result.steps[result.steps.length - 1].outputPath; // set outputPath to last successful step outputPath
+  else {
+    const lastStepWithOutput = [...result.steps].reverse().find(s => s.success && 'outputPath' in s && s.outputPath);
+    if (lastStepWithOutput && 'outputPath' in lastStepWithOutput) {
+      result.outputPath = lastStepWithOutput.outputPath;
+    }
+  }
   return result;
 }

tests/processing/postprocess.test.ts

@@ -132,7 +132,7 @@ describe('postprocess::encrypt', () => {
     const res = await postprocessFile({ config, inputPath: 'in.csv', outputPath: 'out.gpg' });
 
     expect(res.success).toBe(false);
-    expect(res.steps).toEqual([{ success: false, step: 'ENCRYPTION' }]);
+    expect(res.steps).toEqual([{ success: false, step: 'ENCRYPTION', error: 'Recipient key not found' }]);
     expect(res.outputPath).toBeUndefined();
     expect(hoisted.encryptFileMock).toHaveBeenCalledTimes(1);
   });