Validate required columns

Author: wickwirew

Sources/Compiler/Sema/StmtTypeChecker.swift

@@ -439,7 +439,7 @@ extension StmtTypeChecker: StmtSyntaxVisitor {
 extension StmtTypeChecker {
     mutating func typeCheck(
         select: SelectStmtSyntax,
-        potentialNames: [IdentifierSyntax]? = nil
+        potentialNames: [Substring]? = nil
     ) -> ResultColumns {
         typeCheck(with: select.with)
 
@@ -483,7 +483,7 @@ extension StmtTypeChecker {
     mutating func typeCheck(
         selects: SelectStmtSyntax.Selects,
         at location: SourceLocation,
-        potentialNames: [IdentifierSyntax]? = nil
+        potentialNames: [Substring]? = nil
     ) -> ResultColumns {
         switch selects {
         case let .single(selectCore):
@@ -545,26 +545,55 @@ extension StmtTypeChecker {
 
         usedTableNames.insert(table.name.name)
 
+        // If there is an error upstream that will cause unification to fail for sure
+        // we can just skip it so the real error does not get hidden by all the other errors
+        var skipInputUnification = false
+        let columNames: [Substring]
         let inputType: Type
         if let columns = insert.columns {
             var columnTypes: [Type] = []
+            var setColumns: Set<Substring> = []
             for column in columns {
                 guard let def = table.columns[column.value].first else {
                     diagnostics.add(.columnDoesNotExist(column))
                     columnTypes.append(.error)
                     continue
                 }
 
+                if def.isGenerated {
+                    diagnostics.add(.init("Column is generated and not able to be set", at: column.location))
+                }
+                
                 columnTypes.append(def.type)
+                setColumns.insert(column.value)
+            }
+            
+            let requiredColumns = Set(table.requiredColumnsNames)
+            let missingColumns = requiredColumns.subtracting(setColumns)
+            
+            if !missingColumns.isEmpty {
+                let names = missingColumns.map{ "'\($0)'" }.joined(separator: ",")
+                diagnostics.add(.init("Missing required columns \(names)", at: insert.location))
+                // Skip unification since it will fail for sure, and this diag is more specific
+                // to their issue.
+                skipInputUnification = true
             }
+            
             inputType = .row(.fixed(columnTypes))
+            columNames = columns.map(\.value)
         } else {
-            inputType = table.type
+            let columns = table.nonGeneratedColumns
+            inputType = .row(.fixed(columns.map(\.1.type)))
+            columNames = columns.map(\.0)
         }
 
         if let values = insert.values {
-            let resultColumns = typeCheck(select: values.select, potentialNames: insert.columns)
-            inferenceState.unify(inputType, with: resultColumns.type, at: insert.location)
+            let resultColumns = typeCheck(select: values.select, potentialNames: columNames)
+            
+            // Unify the input columns with the actual input values
+            if !skipInputUnification {
+                inferenceState.unify(inputType, with: resultColumns.type, at: insert.location)
+            }
         } else {
             // TODO: Using 'DEFALUT VALUES' make sure all columns
             // TODO: actually have default values or null
@@ -770,7 +799,7 @@ extension StmtTypeChecker {
     private mutating func typeCheck(
         select: SelectCoreSyntax,
         at range: SourceLocation,
-        potentialNames: [IdentifierSyntax]? = nil
+        potentialNames: [Substring]? = nil
     ) -> ResultColumns {
         switch select {
         case let .select(select):
@@ -788,7 +817,7 @@ extension StmtTypeChecker {
                     // If there are potential names to match with check to
                     // see if there is one at the index of this expression.
                     if let potentialNames, index < potentialNames.count {
-                        nameInferrer.suggest(name: potentialNames[index].value, for: name)
+                        nameInferrer.suggest(name: potentialNames[index], for: name)
                     }
                 }
 

Sources/Compiler/Table.swift

@@ -40,6 +40,22 @@ public struct Table: Sendable, Equatable {
         return .row(.fixed(columns.map(\.value.type)))
     }
 
+    /// A set of all required columns that need to be set on insert
+    var nonGeneratedColumns: [(Substring, Column)] {
+        return columns.reduce(into: []) { result, column in
+            guard !column.value.isGenerated else { return }
+            result.append((column.key, column.value))
+        }
+    }
+    
+    /// A set of all required columns that need to be set on insert
+    var requiredColumnsNames: Set<Substring> {
+        return columns.reduce(into: []) { result, column in
+            guard column.value.isRequired else { return }
+            result.insert(column.key)
+        }
+    }
+    
     /// A table to be returned incase of an error in type checking
     static let error = Table(
         name: QualifiedName(name: "<<error>>", schema: nil),

Tests/CompilerTests/Compiler/CompileInsert.sql

@@ -1,4 +1,8 @@
-CREATE TABLE user (id INTEGER, name TEXT);
+CREATE TABLE user (
+    id INTEGER,
+    name TEXT,
+    description TEXT GENERATED ALWAYS AS (name || 'is a user')
+);
 
 -- CHECK: SIGNATURE
 -- CHECK:   PARAMETERS
@@ -29,6 +33,7 @@ INSERT INTO user (id, name) VALUES (?, ?);
 -- CHECK:       OUTPUT
 -- CHECK:         id INTEGER?
 -- CHECK:         name TEXT?
+-- CHECK:         description TEXT?
 -- CHECK:     TABLES
 -- CHECK:       user
 INSERT INTO user (id, name) VALUES (?, ?) RETURNING *;
@@ -64,6 +69,54 @@ INSERT INTO user (id, name) VALUES (?, ?) RETURNING *;
 -- CHECK:       OUTPUT
 -- CHECK:         id INTEGER?
 -- CHECK:         name TEXT?
+-- CHECK:         description TEXT?
 -- CHECK:     TABLES
 -- CHECK:       user
 INSERT INTO user (id, name) VALUES (?, ?), (?, ?), (?, ?) RETURNING *;
+
+-- CHECK: SIGNATURE
+-- CHECK:   PARAMETERS
+-- CHECK:     PARAMETER
+-- CHECK:       TYPE INTEGER?
+-- CHECK:       INDEX 1
+-- CHECK:       NAME id
+-- CHECK:     PARAMETER
+-- CHECK:       TYPE TEXT?
+-- CHECK:       INDEX 2
+-- CHECK:       NAME name
+-- CHECK:     TABLES
+-- CHECK:       user
+INSERT INTO user VALUES (?, ?);
+
+-- CHECK: SIGNATURE
+-- CHECK:   PARAMETERS
+-- CHECK:     PARAMETER
+-- CHECK:       TYPE INTEGER?
+-- CHECK:       INDEX 1
+-- CHECK:       NAME id
+-- CHECK:     PARAMETER
+-- CHECK:       TYPE TEXT?
+-- CHECK:       INDEX 2
+-- CHECK:       NAME name
+-- CHECK:     PARAMETER
+-- CHECK:       TYPE TEXT?
+-- CHECK:       INDEX 3
+-- CHECK:       NAME description
+-- CHECK:   TABLES
+-- CHECK:     user
+-- CHECK-ERROR: Column is generated and not able to be set
+INSERT INTO user (id, name, description) VALUES (?, ?, ?);
+
+-- CHECK: SIGNATURE
+-- CHECK:   PARAMETERS
+-- CHECK:     PARAMETER
+-- CHECK:       TYPE TEXT?
+-- CHECK:       INDEX 1
+-- CHECK:       NAME name
+-- CHECK:     PARAMETER
+-- CHECK:       TYPE INTEGER?
+-- CHECK:       INDEX 2
+-- CHECK:       NAME id
+-- CHECK:     TABLES
+-- CHECK:       user
+INSERT INTO user (name, id) VALUES (?, ?);

Tests/CompilerTests/CompilerTests.swift

@@ -31,7 +31,7 @@ class CompilerTests: XCTestCase {
     }
 
     func testTableSchema() throws {
-        try checkSchema(compile: "CompileTableSchema", dump: true)
+        try checkSchema(compile: "CompileTableSchema")
     }
 
     func testDropTable() throws {