Fixed check not having access to defined column

Author: wickwirew

Sources/Compiler/Sema/Builtins.swift

@@ -140,7 +140,7 @@ enum Builtins {
         "unixepoch": Function(returning: .integer),
         "julianday": Function(returning: .real),
         "strftime": Function(
-            .text,
+            .text, .any,
             returning: .text,
             variadic: true
         ) { _, args, location, diagnostics in

Sources/Compiler/Sema/StmtTypeChecker.swift

@@ -1299,6 +1299,14 @@ extension StmtTypeChecker {
         tableColumns: borrowing Columns,
         tableName: Substring
     ) -> Type {
+        let nominal: Type = .nominal(column.type.name.value)
+        
+        var type: Type = if let alias = column.type.alias {
+            .alias(nominal, .explicit(alias.identifier.value))
+        } else {
+            nominal
+        }
+        
         var isNotNullable = false
         for constraint in column.constraints {
             switch constraint.kind {
@@ -1309,6 +1317,12 @@ extension StmtTypeChecker {
             case let .check(expr):
                 inNewEnvironment { typeChecker in
                     typeChecker.env.import(columns: tableColumns)
+                    // Technically this could be incorrect if the check
+                    // comes before the not null. But it'll do.
+                    typeChecker.env.import(
+                        column: column.name.value,
+                        with: isNotNullable ? type : .optional(type)
+                    )
                     _ = typeChecker.typeCheck(expr)
                 }
             case let .default(expr):
@@ -1353,19 +1367,7 @@ extension StmtTypeChecker {
             ))
         }
 
-        let nominal: Type = .nominal(column.type.name.value)
-        
-        let type: Type = if let alias = column.type.alias {
-            .alias(nominal, .explicit(alias.identifier.value))
-        } else {
-            nominal
-        }
-        
-        if isNotNullable {
-            return type
-        } else {
-            return .optional(type)
-        }
+        return isNotNullable ? type : .optional(type)
     }
 
     private mutating func typeCheck(

Tests/CompilerTests/Compiler/CompileTableSchema.sql

@@ -12,7 +12,7 @@
 -- CHECK:   KIND normal
 CREATE TABLE foo (
     bar INTEGER PRIMARY KEY,
-    baz TEXT
+    baz TEXT CHECK (baz = 'baz')
 );
 
 ALTER TABLE foo ADD COLUMN qux TEXT;