Temporarily remove ruleset GUI from ruleset editor due to NPE thrown WINDUP-3106

Author: johnsteele

plugins/org.jboss.tools.windup.ui/src/org/jboss/tools/windup/ui/internal/rules/OpenRuleDefinitionHandler.java

@@ -56,7 +56,7 @@ public Object execute(ExecutionEvent event) throws ExecutionException {
 					Pair<Object, Node> pair = XMLRulesetModelUtil.findRuleProvider(
 							ruleId, executionBuilder.getSystemRuleProviderRegistry(), modelService);
 					if (pair != null) {
-						XMLRulesetModelUtil.openRuleInEditor(pair.getFirst(), pair.getSecond());
+						XMLRulesetModelUtil.openRuleInEditor(pair.getFirst(), pair.getSecond(), RulesetEditor.ID);
 					}
 				} catch (RemoteException e) {
 					WindupUIPlugin.log(e);

plugins/org.jboss.tools.windup.ui/src/org/jboss/tools/windup/ui/internal/rules/RuleRepositoryContentProvider.java

@@ -97,18 +97,18 @@ else if (parentElement instanceof RuleProvider) {
 			RuleProvider provider = (RuleProvider)parentElement;
 			List<Object> children = Lists.newArrayList();
 			children.add(new RulesetFileNode(provider, new File(provider.getOrigin()), provider.getRuleProviderType()));
-			List<Node> ruleNodes = XMLRulesetModelUtil.getRules(provider.getOrigin());
-			ruleNodes.forEach(node -> nodeMap.put(node, provider));
-			children.addAll(ruleNodes);
+//			List<Node> ruleNodes = XMLRulesetModelUtil.getRules(provider.getOrigin());
+//			ruleNodes.forEach(node -> nodeMap.put(node, provider));
+//			children.addAll(ruleNodes);
 			return children.stream().toArray(Object[]::new);
 		}
 		else if (parentElement instanceof CustomRuleProvider) {
 			CustomRuleProvider provider = (CustomRuleProvider)parentElement;
 			List<Object> children = Lists.newArrayList();
 			children.add(new RulesetFileNode(provider, new File(provider.getLocationURI()), RuleProviderType.XML));
-			List<Node> ruleNodes = XMLRulesetModelUtil.getRules(provider.getLocationURI());
-			ruleNodes.forEach(node -> nodeMap.put(node, provider));
-			children.addAll(ruleNodes);
+//			List<Node> ruleNodes = XMLRulesetModelUtil.getRules(provider.getLocationURI());
+//			ruleNodes.forEach(node -> nodeMap.put(node, provider));
+//			children.addAll(ruleNodes);
 			listen(provider);
 			return children.stream().toArray(Object[]::new);
 		}
@@ -277,12 +277,12 @@ public StyledString getStyledText(Object element) {
 		if (element instanceof SystemRulesNode && ((SystemRulesNode)element).getChildren().length == 0) {
 			style.append(" [" + "Start MTA to view the system rules" + "]", StyledString.DECORATIONS_STYLER);
 		}
-		else if (element instanceof CustomRuleProvider || element instanceof RuleProvider) {
-			style.append(" (" + (getChildren(element).length - 1) + ")", StyledString.COUNTER_STYLER);
-		}
-		else if (element instanceof RulesetFileNode) {
-			style.append(" [" + ((RulesetFileNode)element).getFile().getPath() + "]", StyledString.DECORATIONS_STYLER);
-		}
+//		else if (element instanceof CustomRuleProvider || element instanceof RuleProvider) {
+//			style.append(" (" + (getChildren(element).length - 1) + ")", StyledString.COUNTER_STYLER);
+//		}
+//		else if (element instanceof RulesetFileNode) {
+//			style.append(" [" + ((RulesetFileNode)element).getFile().getPath() + "]", StyledString.DECORATIONS_STYLER);
+//		}
 		return style;
 	}
 

plugins/org.jboss.tools.windup.ui/src/org/jboss/tools/windup/ui/internal/rules/RuleRepositoryView.java

@@ -127,7 +127,8 @@ public void doubleClick(DoubleClickEvent event) {
 					if (element instanceof RulesetFileNode) {
 						RulesetFileNode node = (RulesetFileNode)element;
 						if (node.getRuleProvider() != null) {
-							XMLRulesetModelUtil.openRuleInEditor(node.getRuleProvider(), null);
+//							XMLRulesetModelUtil.openRuleInEditor(node.getRuleProvider(), null, "org.eclipse.wst.xml.ui.internal.tabletree.XMLMultiPageEditorPart");
+							XMLRulesetModelUtil.openRuleInEditor(node.getRuleProvider(), null, RulesetEditor.ID);
 						}
 						/*IFileStore fileStore = EFS.getLocalFileSystem().getStore(new Path(node.getFile().getParent()));
 						fileStore = fileStore.getChild(node.getName());
@@ -148,7 +149,7 @@ else if (element instanceof Node) {
 						Node node = (Node)element;
 						Object provider = contentProvider.getProvider(node);
 						if (provider != null) {
-							XMLRulesetModelUtil.openRuleInEditor(provider, node);
+							XMLRulesetModelUtil.openRuleInEditor(provider, node, RulesetEditor.ID);
 						}
 					}
 				}
@@ -214,7 +215,7 @@ else if (resource != null && resource.exists()){
 						}
     						boolean exists = modelService.ruleProviderExists(resource.getFullPath().toString());
     						if (!exists) {
-							modelService.addRulesetRepository(rulesetLocation, resource.getFullPath().toString());
+    							modelService.addRulesetRepository(rulesetLocation, resource.getFullPath().toString());
     						}
 					}
 				}

plugins/org.jboss.tools.windup.ui/src/org/jboss/tools/windup/ui/internal/rules/RulesetEditorWrapper.java

@@ -15,6 +15,7 @@
 import org.eclipse.e4.core.contexts.IEclipseContext;
 import org.eclipse.jface.text.IDocument;
 import org.eclipse.jface.viewers.ISelectionProvider;
+import org.eclipse.jface.viewers.StructuredSelection;
 import org.eclipse.swt.custom.CTabFolder;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Control;
@@ -36,7 +37,7 @@
 @SuppressWarnings("restriction")
 public class RulesetEditorWrapper extends XMLMultiPageEditorPart {
 
-	private RulesetDesignPage designPage;
+//	private RulesetDesignPage designPage;
 
 	@SuppressWarnings("rawtypes")
 	@Override
@@ -90,7 +91,7 @@ protected IDesignViewer createDesignPage() {
 	@Override
 	public void dispose() {
 		super.dispose();
-		designPage.dispose();
+//		designPage.dispose();
 	}
 
 	@Override
@@ -99,16 +100,21 @@ public void setFocus() {
 	}
 
 	public Document getDocument() {
-		return designPage.getDocument();
+		return (Document)this.getAdapter(IDocument.class);
+//		return designPage.getDocument();
 	}
 
+//	
 	public void selectAndReveal(Element element) {
-		designPage.getEditor().selectAndReveal(element);
+		super.getEditorSite().getSelectionProvider().setSelection(new StructuredSelection(element));
+//		designPage.getEditor().selectAndReveal(element);
 	}
+//	
+//	public IElementUiDelegate getUiDelegate(Element element) {
+//		return designPage.getEditor().getUiDelegate(element);
+//	}
+	
 
-	public IElementUiDelegate getUiDelegate(Element element) {
-		return designPage.getEditor().getUiDelegate(element);
-	}
 
 	public static final class RulesetDesignPage implements IDesignViewer {