Fixes for scan-build warnings.

Author: dgarske

wolfcrypt/src/port/intel/quickassist.c

@@ -70,6 +70,8 @@
     #include <wolfcrypt/src/misc.c>
 #endif
 
+#include <pthread.h>
+
 /* Async enables (1=non-block, 0=block) */
 #ifndef QAT_RSA_ASYNC
 #define QAT_RSA_ASYNC        1
@@ -802,6 +804,7 @@ static int IntelQaPollBlockRet(WC_ASYNC_DEV* dev, int ret_wait)
 
     do {
         ret = IntelQaPoll(dev);
+        (void)ret; /* not used */
 
         if (dev->qat.ret != ret_wait) {
             break;
@@ -1996,9 +1999,10 @@ static int IntelQaSymOpen(WC_ASYNC_DEV* dev, CpaCySymSessionSetupData* setup,
     /* Determine size of session context to allocate - use max size */
     status = cpaCySymSessionCtxGetSize(dev->qat.handle, setup, &sessionCtxSize);
 
-    if (ctx->symCtxSize > 0 && ctx->symCtxSize > sessionCtxSize) {
-        printf("Symmetric context size error! Buf %d, Exp %d\n",
-            ctx->symCtxSize, sessionCtxSize);
+    if (status != CPA_STATUS_SUCCESS || (ctx->symCtxSize > 0 &&
+                                         ctx->symCtxSize > sessionCtxSize)) {
+        printf("Symmetric context size error %d! Buf %d, Exp %d\n",
+            status, ctx->symCtxSize, sessionCtxSize);
         return ASYNC_OP_E;
     }
 
@@ -3797,14 +3801,11 @@ static void IntelQaEcdsaSignCallback(void *pCallbackTag,
             ret = ECC_CURVE_OID_E;
         }
         else {
-            /* mark event result */
-            ret = 0; /* success */
-        }
-
-        /* populate result */
-        ret = IntelQaFlatBufferToBigInt(pR, dev->qat.op.ecc_sign.pR);
-        if (ret == 0) {
-            ret = IntelQaFlatBufferToBigInt(pS, dev->qat.op.ecc_sign.pS);
+            /* success - populate result */
+            ret = IntelQaFlatBufferToBigInt(pR, dev->qat.op.ecc_sign.pR);
+            if (ret == 0) {
+                ret = IntelQaFlatBufferToBigInt(pS, dev->qat.op.ecc_sign.pS);
+            }
         }
     }
     (void)opData;

wolfcrypt/src/port/intel/quickassist_mem.c

@@ -36,8 +36,8 @@
 #include <string.h>
 
 /* use thread local for QAE variables (removing mutex requirement) */
+#include <pthread.h> /* for threadId tracking */
 #ifdef USE_QAE_THREAD_LS
-    #include <pthread.h> /* for threadId tracking */
     #define QAE_THREAD_LS THREAD_LS_T
 #else
     #define QAE_THREAD_LS