Added checks for optional delegate method.

bummytime · bummytime · commit 34132865bbf1 · 2017-08-22T10:24:04.000-05:00
diff --git a/Classes/WPEditorViewController.m b/Classes/WPEditorViewController.m
@@ -354,7 +354,9 @@ - (void)didTouchMediaOptions
                            animated:YES
                          completion:nil];
     }
-    [self.delegate editorTrackStat:WPEditorStatTappedImage];
+    if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+        [self.delegate editorTrackStat:WPEditorStatTappedImage];
+    }
 }
 
 #pragma mark - Editor and Misc Methods
@@ -518,7 +520,9 @@ - (void)showHTMLSource:(UIBarButtonItem *)barButtonItem
                                  setSelected:NO];
     }
 
-    [self.delegate editorTrackStat:WPEditorStatTappedHTML];
+    if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+        [self.delegate editorTrackStat:WPEditorStatTappedHTML];
+    }
 }
 
 - (void)removeFormat
@@ -550,21 +554,27 @@ - (void)setBold
 {
     [self.editorView setBold];
     [self clearToolbar];
-    [self.delegate editorTrackStat:WPEditorStatTappedBold];
+    if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+        [self.delegate editorTrackStat:WPEditorStatTappedBold];
+    }
 }
 
 - (void)setBlockQuote
 {
     [self.editorView setBlockQuote];
     [self clearToolbar];
-    [self.delegate editorTrackStat:WPEditorStatTappedBlockquote];
+    if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+        [self.delegate editorTrackStat:WPEditorStatTappedBlockquote];
+    }
 }
 
 - (void)setItalic
 {
     [self.editorView setItalic];
     [self clearToolbar];
-    [self.delegate editorTrackStat:WPEditorStatTappedItalic];
+    if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+        [self.delegate editorTrackStat:WPEditorStatTappedItalic];
+    }
 }
 
 - (void)setSubscript
@@ -576,7 +586,9 @@ - (void)setUnderline
 {
 	[self.editorView setUnderline];
     [self clearToolbar];
-    [self.delegate editorTrackStat:WPEditorStatTappedUnderline];
+    if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+        [self.delegate editorTrackStat:WPEditorStatTappedUnderline];
+    }
 }
 
 - (void)setSuperscript
@@ -588,21 +600,27 @@ - (void)setStrikethrough
 {
     [self.editorView setStrikethrough];
     [self clearToolbar];
-    [self.delegate editorTrackStat:WPEditorStatTappedStrikethrough];
+    if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+        [self.delegate editorTrackStat:WPEditorStatTappedStrikethrough];
+    }
 }
 
 - (void)setUnorderedList
 {
     [self.editorView setUnorderedList];
     [self clearToolbar];
-    [self.delegate editorTrackStat:WPEditorStatTappedUnorderedList];
+    if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+        [self.delegate editorTrackStat:WPEditorStatTappedUnorderedList];
+    }
 }
 
 - (void)setOrderedList
 {
     [self.editorView setOrderedList];
     [self clearToolbar];
-    [self.delegate editorTrackStat:WPEditorStatTappedOrderedList];
+    if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+        [self.delegate editorTrackStat:WPEditorStatTappedOrderedList];
+    }
 }
 
 - (void)setHR
@@ -698,7 +716,9 @@ - (void)linkBarButtonTapped
 	} else {
 		[self showInsertLinkDialogWithLink:self.editorView.selectedLinkURL
 									 title:[self.editorView selectedText]];
-        [self.delegate editorTrackStat:WPEditorStatTappedLink];
+        if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+            [self.delegate editorTrackStat:WPEditorStatTappedLink];
+        }
 	}
 }
 
@@ -822,7 +842,9 @@ - (void)updateLink:(NSString *)url
 - (void)removeLink
 {
     [self.editorView removeLink];
-    [self.delegate editorTrackStat:WPEditorStatTappedUnlink];
+    if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+        [self.delegate editorTrackStat:WPEditorStatTappedUnlink];
+    }
 }
 
 - (void)quickLink
diff --git a/Classes/WPLegacyEditorViewController.m b/Classes/WPLegacyEditorViewController.m
@@ -443,28 +443,44 @@ - (void)formatToolbar:(WPLegacyEditorFormatToolbar *)formatToolbar actionPressed
 {
     switch (formatAction) {
         case WPLegacyEditorFormatActionBold:
-            [self.delegate editorTrackStat:WPEditorStatTappedBold];
+            if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+                [self.delegate editorTrackStat:WPEditorStatTappedBold];
+            }
             break;
         case WPLegacyEditorFormatActionItalic:
-            [self.delegate editorTrackStat:WPEditorStatTappedItalic];
+            if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+                [self.delegate editorTrackStat:WPEditorStatTappedItalic];
+            }
             break;
         case WPLegacyEditorFormatActionUnderline:
-            [self.delegate editorTrackStat:WPEditorStatTappedUnderline];
+            if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+                [self.delegate editorTrackStat:WPEditorStatTappedUnderline];
+            }
             break;
         case WPLegacyEditorFormatActionDelete:
-            [self.delegate editorTrackStat:WPEditorStatTappedStrikethrough];
+            if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+                [self.delegate editorTrackStat:WPEditorStatTappedStrikethrough];
+            }
             break;
         case WPLegacyEditorFormatActionLink:
-            [self.delegate editorTrackStat:WPEditorStatTappedLink];
+            if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+                [self.delegate editorTrackStat:WPEditorStatTappedLink];
+            }
             break;
         case WPLegacyEditorFormatActionQuote:
-            [self.delegate editorTrackStat:WPEditorStatTappedBlockquote];
+            if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+                [self.delegate editorTrackStat:WPEditorStatTappedBlockquote];
+            }
             break;
         case WPLegacyEditorFormatActionMore:
-            [self.delegate editorTrackStat:WPEditorStatTappedMore];
+            if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+                [self.delegate editorTrackStat:WPEditorStatTappedMore];
+            }
             break;
         case WPLegacyEditorFormatActionMedia:
-            [self.delegate editorTrackStat:WPEditorStatTappedImage];
+            if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {
+                [self.delegate editorTrackStat:WPEditorStatTappedImage];
+            }
             break;
 
     }
diff --git a/Example/EditorDemo/WPViewController.m b/Example/EditorDemo/WPViewController.m
@@ -118,6 +118,10 @@ - (void)editorViewController:(WPEditorViewController *)editorViewController fiel
     DDLogInfo(@"Editor field created: %@", field.nodeId);
 }
 
+- (void)editorTrackStat:(WPEditorStat)stat {
+    DDLogInfo(@"Editor stat tracked: %lu", (unsigned long)stat);
+}
+
 - (void)editorViewController:(WPEditorViewController*)editorViewController
                  imageTapped:(NSString *)imageId
                          url:(NSURL *)url

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,9 @@ - (void)didTouchMediaOptions`
`354`	`354`	`animated:YES`
`355`	`355`	`completion:nil];`
`356`	`356`	`}`
`357`		`- [self.delegate editorTrackStat:WPEditorStatTappedImage];`
	`357`	`+ if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {`
	`358`	`+ [self.delegate editorTrackStat:WPEditorStatTappedImage];`
	`359`	`+ }`
`358`	`360`	`}`
`359`	`361`
`360`	`362`	`#pragma mark - Editor and Misc Methods`
`@@ -518,7 +520,9 @@ - (void)showHTMLSource:(UIBarButtonItem *)barButtonItem`
`518`	`520`	`setSelected:NO];`
`519`	`521`	`}`
`520`	`522`
`521`		`- [self.delegate editorTrackStat:WPEditorStatTappedHTML];`
	`523`	`+ if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {`
	`524`	`+ [self.delegate editorTrackStat:WPEditorStatTappedHTML];`
	`525`	`+ }`
`522`	`526`	`}`
`523`	`527`
`524`	`528`	`- (void)removeFormat`
`@@ -550,21 +554,27 @@ - (void)setBold`
`550`	`554`	`{`
`551`	`555`	`[self.editorView setBold];`
`552`	`556`	`[self clearToolbar];`
`553`		`- [self.delegate editorTrackStat:WPEditorStatTappedBold];`
	`557`	`+ if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {`
	`558`	`+ [self.delegate editorTrackStat:WPEditorStatTappedBold];`
	`559`	`+ }`
`554`	`560`	`}`
`555`	`561`
`556`	`562`	`- (void)setBlockQuote`
`557`	`563`	`{`
`558`	`564`	`[self.editorView setBlockQuote];`
`559`	`565`	`[self clearToolbar];`
`560`		`- [self.delegate editorTrackStat:WPEditorStatTappedBlockquote];`
	`566`	`+ if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {`
	`567`	`+ [self.delegate editorTrackStat:WPEditorStatTappedBlockquote];`
	`568`	`+ }`
`561`	`569`	`}`
`562`	`570`
`563`	`571`	`- (void)setItalic`
`564`	`572`	`{`
`565`	`573`	`[self.editorView setItalic];`
`566`	`574`	`[self clearToolbar];`
`567`		`- [self.delegate editorTrackStat:WPEditorStatTappedItalic];`
	`575`	`+ if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {`
	`576`	`+ [self.delegate editorTrackStat:WPEditorStatTappedItalic];`
	`577`	`+ }`
`568`	`578`	`}`
`569`	`579`
`570`	`580`	`- (void)setSubscript`
`@@ -576,7 +586,9 @@ - (void)setUnderline`
`576`	`586`	`{`
`577`	`587`	`[self.editorView setUnderline];`
`578`	`588`	`[self clearToolbar];`
`579`		`- [self.delegate editorTrackStat:WPEditorStatTappedUnderline];`
	`589`	`+ if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {`
	`590`	`+ [self.delegate editorTrackStat:WPEditorStatTappedUnderline];`
	`591`	`+ }`
`580`	`592`	`}`
`581`	`593`
`582`	`594`	`- (void)setSuperscript`
`@@ -588,21 +600,27 @@ - (void)setStrikethrough`
`588`	`600`	`{`
`589`	`601`	`[self.editorView setStrikethrough];`
`590`	`602`	`[self clearToolbar];`
`591`		`- [self.delegate editorTrackStat:WPEditorStatTappedStrikethrough];`
	`603`	`+ if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {`
	`604`	`+ [self.delegate editorTrackStat:WPEditorStatTappedStrikethrough];`
	`605`	`+ }`
`592`	`606`	`}`
`593`	`607`
`594`	`608`	`- (void)setUnorderedList`
`595`	`609`	`{`
`596`	`610`	`[self.editorView setUnorderedList];`
`597`	`611`	`[self clearToolbar];`
`598`		`- [self.delegate editorTrackStat:WPEditorStatTappedUnorderedList];`
	`612`	`+ if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {`
	`613`	`+ [self.delegate editorTrackStat:WPEditorStatTappedUnorderedList];`
	`614`	`+ }`
`599`	`615`	`}`
`600`	`616`
`601`	`617`	`- (void)setOrderedList`
`602`	`618`	`{`
`603`	`619`	`[self.editorView setOrderedList];`
`604`	`620`	`[self clearToolbar];`
`605`		`- [self.delegate editorTrackStat:WPEditorStatTappedOrderedList];`
	`621`	`+ if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {`
	`622`	`+ [self.delegate editorTrackStat:WPEditorStatTappedOrderedList];`
	`623`	`+ }`
`606`	`624`	`}`
`607`	`625`
`608`	`626`	`- (void)setHR`
`@@ -698,7 +716,9 @@ - (void)linkBarButtonTapped`
`698`	`716`	`} else {`
`699`	`717`	`[self showInsertLinkDialogWithLink:self.editorView.selectedLinkURL`
`700`	`718`	`title:[self.editorView selectedText]];`
`701`		`- [self.delegate editorTrackStat:WPEditorStatTappedLink];`
	`719`	`+ if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {`
	`720`	`+ [self.delegate editorTrackStat:WPEditorStatTappedLink];`
	`721`	`+ }`
`702`	`722`	`}`
`703`	`723`	`}`
`704`	`724`
`@@ -822,7 +842,9 @@ - (void)updateLink:(NSString *)url`
`822`	`842`	`- (void)removeLink`
`823`	`843`	`{`
`824`	`844`	`[self.editorView removeLink];`
`825`		`- [self.delegate editorTrackStat:WPEditorStatTappedUnlink];`
	`845`	`+ if ([self.delegate respondsToSelector: @selector(editorTrackStat:)]) {`
	`846`	`+ [self.delegate editorTrackStat:WPEditorStatTappedUnlink];`
	`847`	`+ }`
`826`	`848`	`}`
`827`	`849`
`828`	`850`	`- (void)quickLink`