Skip to content
This repository was archived by the owner on Dec 13, 2017. It is now read-only.

Commit a64d9ed

Browse files
committed
Remove analytics
This will help move the analytics pod inside the main repo. We could figure out some way to inject trackers into the editor, but I think we don't really need to collect more data on popular toolbar buttons (and if we do, there are better ways).
1 parent 584d11b commit a64d9ed

5 files changed

Lines changed: 2 additions & 50 deletions

File tree

Classes/WPEditorViewController.m

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
#import "WPEditorViewController.h"
22
#import <MobileCoreServices/MobileCoreServices.h>
33
#import <UIKit/UIKit.h>
4-
#import <WordPressComAnalytics/WPAnalytics.h>
54

65
#import "WPEditorField.h"
76
#import "WPEditorToolbarButton.h"
@@ -355,7 +354,6 @@ - (void)didTouchMediaOptions
355354
animated:YES
356355
completion:nil];
357356
}
358-
[WPAnalytics track:WPAnalyticsStatEditorTappedImage];
359357
}
360358

361359
#pragma mark - Editor and Misc Methods
@@ -518,8 +516,6 @@ - (void)showHTMLSource:(UIBarButtonItem *)barButtonItem
518516
[self.toolbarView toolBarItemWithTag:kWPEditorViewControllerElementShowSourceBarButton
519517
setSelected:NO];
520518
}
521-
522-
[WPAnalytics track:WPAnalyticsStatEditorTappedHTML];
523519
}
524520

525521
- (void)removeFormat
@@ -551,21 +547,18 @@ - (void)setBold
551547
{
552548
[self.editorView setBold];
553549
[self clearToolbar];
554-
[WPAnalytics track:WPAnalyticsStatEditorTappedBold];
555550
}
556551

557552
- (void)setBlockQuote
558553
{
559554
[self.editorView setBlockQuote];
560555
[self clearToolbar];
561-
[WPAnalytics track:WPAnalyticsStatEditorTappedBlockquote];
562556
}
563557

564558
- (void)setItalic
565559
{
566560
[self.editorView setItalic];
567561
[self clearToolbar];
568-
[WPAnalytics track:WPAnalyticsStatEditorTappedItalic];
569562
}
570563

571564
- (void)setSubscript
@@ -577,7 +570,6 @@ - (void)setUnderline
577570
{
578571
[self.editorView setUnderline];
579572
[self clearToolbar];
580-
[WPAnalytics track:WPAnalyticsStatEditorTappedUnderline];
581573
}
582574

583575
- (void)setSuperscript
@@ -589,21 +581,18 @@ - (void)setStrikethrough
589581
{
590582
[self.editorView setStrikethrough];
591583
[self clearToolbar];
592-
[WPAnalytics track:WPAnalyticsStatEditorTappedStrikethrough];
593584
}
594585

595586
- (void)setUnorderedList
596587
{
597588
[self.editorView setUnorderedList];
598589
[self clearToolbar];
599-
[WPAnalytics track:WPAnalyticsStatEditorTappedUnorderedList];
600590
}
601591

602592
- (void)setOrderedList
603593
{
604594
[self.editorView setOrderedList];
605595
[self clearToolbar];
606-
[WPAnalytics track:WPAnalyticsStatEditorTappedOrderedList];
607596
}
608597

609598
- (void)setHR
@@ -699,7 +688,6 @@ - (void)linkBarButtonTapped
699688
} else {
700689
[self showInsertLinkDialogWithLink:self.editorView.selectedLinkURL
701690
title:[self.editorView selectedText]];
702-
[WPAnalytics track:WPAnalyticsStatEditorTappedLink];
703691
}
704692
}
705693

@@ -823,7 +811,6 @@ - (void)updateLink:(NSString *)url
823811
- (void)removeLink
824812
{
825813
[self.editorView removeLink];
826-
[WPAnalytics track:WPAnalyticsStatEditorTappedUnlink];
827814
}
828815

829816
- (void)quickLink

Classes/WPLegacyEditorViewController.m

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
#import "WPLegacyEditorViewController.h"
22
#import "WPLegacyEditorFormatToolbar.h"
33
#import "WPLegacyEditorFormatAction.h"
4-
#import <WordPressComAnalytics/WPAnalytics.h>
54

65
CGFloat const WPLegacyEPVCStandardOffset = 15.0;
76
CGFloat const WPLegacyEPVCTextViewOffset = 10.0;
@@ -442,34 +441,6 @@ - (void)wrapSelectionWithTag:(NSString *)tag
442441

443442
- (void)formatToolbar:(WPLegacyEditorFormatToolbar *)formatToolbar actionPressed:(WPLegacyEditorFormatAction)formatAction
444443
{
445-
switch (formatAction) {
446-
case WPLegacyEditorFormatActionBold:
447-
[WPAnalytics track:WPAnalyticsStatEditorTappedBold];
448-
break;
449-
case WPLegacyEditorFormatActionItalic:
450-
[WPAnalytics track:WPAnalyticsStatEditorTappedItalic];
451-
break;
452-
case WPLegacyEditorFormatActionUnderline:
453-
[WPAnalytics track:WPAnalyticsStatEditorTappedUnderline];
454-
break;
455-
case WPLegacyEditorFormatActionDelete:
456-
[WPAnalytics track:WPAnalyticsStatEditorTappedStrikethrough];
457-
break;
458-
case WPLegacyEditorFormatActionLink:
459-
[WPAnalytics track:WPAnalyticsStatEditorTappedLink];
460-
break;
461-
case WPLegacyEditorFormatActionQuote:
462-
[WPAnalytics track:WPAnalyticsStatEditorTappedBlockquote];
463-
break;
464-
case WPLegacyEditorFormatActionMore:
465-
[WPAnalytics track:WPAnalyticsStatEditorTappedMore];
466-
break;
467-
case WPLegacyEditorFormatActionMedia:
468-
[WPAnalytics track:WPAnalyticsStatEditorTappedImage];
469-
break;
470-
471-
}
472-
473444
if (formatAction == WPLegacyEditorFormatActionMedia) {
474445
[self didTouchMediaOptions];
475446
} else if (formatAction == WPLegacyEditorFormatActionLink) {

Example/Podfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ use_frameworks!
66
target 'EditorDemo' do
77
pod 'WordPress-iOS-Editor', :path => '../'
88
pod 'CocoaLumberjack', '~> 3.2.0', :inhibit_warnings => true
9-
pod 'WordPressCom-Analytics-iOS', '~>0.1.0', :inhibit_warnings => true
109
end
1110

1211
target 'EditorDemoTests' do

Example/Podfile.lock

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,10 @@ PODS:
99
- WordPress-iOS-Editor (1.9.2):
1010
- CocoaLumberjack (~> 3.2.0)
1111
- NSObject-SafeExpectations (~> 0.0.2)
12-
- WordPressCom-Analytics-iOS (~> 0.1.0)
13-
- WordPressCom-Analytics-iOS (0.1.25)
1412

1513
DEPENDENCIES:
1614
- CocoaLumberjack (~> 3.2.0)
1715
- WordPress-iOS-Editor (from `../`)
18-
- WordPressCom-Analytics-iOS (~> 0.1.0)
1916

2017
EXTERNAL SOURCES:
2118
WordPress-iOS-Editor:
@@ -24,9 +21,8 @@ EXTERNAL SOURCES:
2421
SPEC CHECKSUMS:
2522
CocoaLumberjack: 9b4aed7073d242f29cc2f62068d995faf67f703a
2623
NSObject-SafeExpectations: 7d7f48df90df4e11da7cfe86b64f45eff7a7f521
27-
WordPress-iOS-Editor: e71fa013ac3bf8f448d0ee43421beed3f56500f0
28-
WordPressCom-Analytics-iOS: ec36976259d733430ba0fc2f8a51765947d2c7ba
24+
WordPress-iOS-Editor: 0965aff97450d0569e15e5bf0b5332b028198257
2925

30-
PODFILE CHECKSUM: 9d7155cbcbabb6020cd8a669ba72e4ae0a4b1e20
26+
PODFILE CHECKSUM: cb6a541ba5f4aad4728b3cc32bb1c0621d6f7bfa
3127

3228
COCOAPODS: 1.2.1

WordPress-iOS-Editor.podspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ Pod::Spec.new do |s|
1919
s.exclude_files = 'Classes/exclude'
2020
s.requires_arc = true
2121
s.dependency 'CocoaLumberjack', '~> 3.2.0'
22-
s.dependency 'WordPressCom-Analytics-iOS', '~>0.1.0'
2322
s.dependency 'NSObject-SafeExpectations', '~>0.0.2'
2423
s.header_dir = 'WordPressEditor'
2524
end

0 commit comments

Comments
 (0)