Skip to content

Commit 30a989a

Browse files
authored
Merge pull request #137 from wyeworks/clean_unused_error_code
Remove unused auto-generated errors helpers code
2 parents e4264da + 15584f3 commit 30a989a

6 files changed

Lines changed: 3 additions & 74 deletions

File tree

.github/workflows/elixir.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ jobs:
2222
restore-keys: ${{ runner.os }}-mix-
2323
- name: Install mix dependencies
2424
run: mix deps.get
25+
- name: Check unused mix dependencies
26+
run: mix deps.unlock --check-unused
2527
- name: Check code format
2628
run: mix format --check-formatted
2729
- name: Install yarn dependencies

lib/elixir_console_web.ex

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ defmodule ElixirConsoleWeb do
2222
use Phoenix.Controller, namespace: ElixirConsoleWeb
2323

2424
import Plug.Conn
25-
import ElixirConsoleWeb.Gettext
2625
alias ElixirConsoleWeb.Router.Helpers, as: Routes
2726
import Phoenix.LiveView.Controller
2827
end
@@ -41,8 +40,6 @@ defmodule ElixirConsoleWeb do
4140
# Use all HTML functionality (forms, tags, etc)
4241
use Phoenix.HTML
4342

44-
import ElixirConsoleWeb.ErrorHelpers
45-
import ElixirConsoleWeb.Gettext
4643
alias ElixirConsoleWeb.Router.Helpers, as: Routes
4744
end
4845
end

lib/elixir_console_web/gettext.ex

Lines changed: 0 additions & 24 deletions
This file was deleted.

lib/elixir_console_web/views/error_helpers.ex

Lines changed: 0 additions & 44 deletions
This file was deleted.

mix.exs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ defmodule ElixirConsole.MixProject do
77
version: "0.1.0",
88
elixir: "~> 1.12.3",
99
elixirc_paths: elixirc_paths(Mix.env()),
10-
compilers: [:phoenix, :gettext] ++ Mix.compilers(),
10+
compilers: [:phoenix] ++ Mix.compilers(),
1111
start_permanent: Mix.env() == :prod,
1212
aliases: aliases(),
1313
deps: deps()
@@ -37,7 +37,6 @@ defmodule ElixirConsole.MixProject do
3737
{:phoenix_live_view, "~> 0.14.0"},
3838
{:phoenix_html, "~> 2.14"},
3939
{:phoenix_live_reload, "~> 1.3", only: :dev},
40-
{:gettext, "~> 0.11"},
4140
{:jason, "~> 1.0"},
4241
{:plug_cowboy, "~> 2.1"},
4342
{:earmark, "~> 1.4.0"},

mix.lock

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"earmark_parser": {:hex, :earmark_parser, "1.4.15", "b29e8e729f4aa4a00436580dcc2c9c5c51890613457c193cc8525c388ccb2f06", [:mix], [], "hexpm", "044523d6438ea19c1b8ec877ec221b008661d3c27e3b848f4c879f500421ca5c"},
99
"file_system": {:hex, :file_system, "0.2.10", "fb082005a9cd1711c05b5248710f8826b02d7d1784e7c3451f9c1231d4fc162d", [:mix], [], "hexpm", "41195edbfb562a593726eda3b3e8b103a309b733ad25f3d642ba49696bf715dc"},
1010
"floki": {:hex, :floki, "0.26.0", "4df88977e2e357c6720e1b650f613444bfb48c5acfc6a0c646ab007d08ad13bf", [:mix], [{:html_entities, "~> 0.5.0", [hex: :html_entities, repo: "hexpm", optional: false]}], "hexpm", "e7b66ce7feef5518a9cd9fc7b52dd62a64028bd9cb6d6ad282a0f0fc90a4ae52"},
11-
"gettext": {:hex, :gettext, "0.17.0", "abe21542c831887a2b16f4c94556db9c421ab301aee417b7c4fbde7fbdbe01ec", [:mix], [], "hexpm", "e0b8598e802676c81e66b061a2148c37c03886b24a3ca86a1f98ed40693b94b3"},
1211
"hackney": {:hex, :hackney, "1.15.1", "9f8f471c844b8ce395f7b6d8398139e26ddca9ebc171a8b91342ee15a19963f4", [:rebar3], [{:certifi, "2.5.1", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "6.0.0", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "1.0.1", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "~>1.1", [hex: :mimerl, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "1.1.4", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}], "hexpm", "c2790c9f0f7205f4a362512192dee8179097394400e745e4d20bab7226a8eaad"},
1312
"html_entities": {:hex, :html_entities, "0.5.1", "1c9715058b42c35a2ab65edc5b36d0ea66dd083767bef6e3edb57870ef556549", [:mix], [], "hexpm", "30efab070904eb897ff05cd52fa61c1025d7f8ef3a9ca250bc4e6513d16c32de"},
1413
"httpoison": {:hex, :httpoison, "1.5.1", "0f55b5b673b03c5c327dac7015a67cb571b99b631acc0bc1b0b98dcd6b9f2104", [:mix], [{:hackney, "~> 1.8", [hex: :hackney, repo: "hexpm", optional: false]}], "hexpm", "191a3b6329c917de4e7ca68431919a59bf19e60694b313a69bc1f56a4cb160bf"},

0 commit comments

Comments
 (0)