Skip to content

Commit be914d1

Browse files
committed
Fix ty type checker rule name: possibly-unbound-attribute -> possibly-missing-attribute
- Updated pyproject.toml to use correct rule name - Updated documentation to reflect correct rule name - Minor styling updates in metrics.py - Notebook execution count updates
1 parent ac9e32b commit be914d1

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

docs/dev/type-checking.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ make ci-check
4040
The following error types are ignored because they're inherent to pandas/numpy/faiss usage:
4141

4242
- **unresolved-reference**: Dynamic pandas/numpy attributes (`.empty`, `.idxmax`, `.isna`, etc.)
43-
- **possibly-unbound-attribute**: Complex pandas/numpy operations
43+
- **possibly-missing-attribute**: Complex pandas/numpy operations
4444
- **unresolved-import**: Optional dependencies like FAISS
4545

4646
## Expected Behavior

examples/fastwoe_styled_display.ipynb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1178,7 +1178,7 @@
11781178
},
11791179
{
11801180
"cell_type": "code",
1181-
"execution_count": null,
1181+
"execution_count": 9,
11821182
"metadata": {},
11831183
"outputs": [
11841184
{
@@ -1353,7 +1353,7 @@
13531353
},
13541354
{
13551355
"cell_type": "code",
1356-
"execution_count": null,
1356+
"execution_count": 10,
13571357
"metadata": {},
13581358
"outputs": [
13591359
{
@@ -1973,7 +1973,7 @@
19731973
],
19741974
"metadata": {
19751975
"kernelspec": {
1976-
"display_name": ".venv (3.14.0)",
1976+
"display_name": ".venv (3.11.8)",
19771977
"language": "python",
19781978
"name": "python3"
19791979
},
@@ -1987,7 +1987,7 @@
19871987
"name": "python",
19881988
"nbconvert_exporter": "python",
19891989
"pygments_lexer": "ipython3",
1990-
"version": "3.14.0"
1990+
"version": "3.11.8"
19911991
}
19921992
},
19931993
"nbformat": 4,

fastwoe/metrics.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,9 +283,9 @@ def value_formatter(x, p):
283283
)
284284

285285
ax.xaxis.set_major_formatter(plt.FuncFormatter(value_formatter))
286-
ax.set_xlabel(xlabel, fontsize=11, fontweight="bold")
286+
ax.set_xlabel(xlabel, fontsize=12, fontfamily="Arial")
287287
ax.set_ylabel("")
288-
ax.set_title(f"WOE: {feature_name}", fontsize=13, fontweight="bold")
288+
ax.set_title(f"WOE: {feature_name}", fontsize=12, fontfamily="Arial")
289289
ax.grid(axis="x", alpha=0.3, linestyle="--")
290290
ax.legend(loc="best")
291291

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ disable = [
189189
"C0415", # import-outside-toplevel (common in tests for mocking)
190190
"R1714", # consider-using-in (minor style preference)
191191
"E0401", # import-error (dependencies should be available)
192-
"E0611", # no-name-in-module (scipy.special.expit exists but linter can't find it)
192+
"E0611", # no-name-in-module (module exists but linter can't find it)
193193
]
194194

195195
[tool.pylint.format]
@@ -204,7 +204,7 @@ init-hook = "import sys; sys.path.insert(0, 'typings')"
204204
# ty type checker configuration
205205
[tool.ty.rules]
206206
unresolved-reference = "ignore"
207-
possibly-unbound-attribute = "ignore"
207+
possibly-missing-attribute = "ignore"
208208
unresolved-import = "ignore"
209209

210210
# Include our type stubs directory in the src path

0 commit comments

Comments
 (0)