xapi-stdext-std: Delete unused xstringext methods

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>

Author: psafont

ocaml/libs/xapi-stdext/lib/xapi-stdext-std/xstringext.ml

@@ -12,31 +12,6 @@
  * GNU Lesser General Public License for more details.
  *)
 module String = struct
-  let of_char c = String.make 1 c
-
-  let rev_map f string =
-    let n = String.length string in
-    String.init n (fun i -> f string.[n - i - 1])
-
-  let rev_iter f string =
-    for i = String.length string - 1 downto 0 do
-      f string.[i]
-    done
-
-  let fold_left f accu string =
-    let accu = ref accu in
-    for i = 0 to String.length string - 1 do
-      accu := f !accu string.[i]
-    done ;
-    !accu
-
-  let fold_right f string accu =
-    let accu = ref accu in
-    for i = String.length string - 1 downto 0 do
-      accu := f string.[i] !accu
-    done ;
-    !accu
-
   (** Returns true for whitespace characters, false otherwise *)
   let isspace = function ' ' | '\n' | '\r' | '\t' -> true | _ -> false
 
@@ -174,8 +149,4 @@ module String = struct
         String.escaped s
     | Some rules ->
         map_unlikely s (fun c -> List.assoc_opt c rules)
-
-  let sub_before c s = String.sub s 0 (String.index s c)
-
-  let sub_after c s = sub_to_end s (String.index s c + 1)
 end

ocaml/libs/xapi-stdext/lib/xapi-stdext-std/xstringext.mli

@@ -12,21 +12,6 @@
  * GNU Lesser General Public License for more details.
  *)
 module String : sig
-  val of_char : char -> string
-
-  val rev_map : (char -> char) -> string -> string
-  (** Map a string to a string, applying the given function in reverse
-      order. *)
-
-  val rev_iter : (char -> unit) -> string -> unit
-  (** Iterate over the characters in a string in reverse order. *)
-
-  val fold_left : ('a -> char -> 'a) -> 'a -> string -> 'a
-  (** Fold over the characters in a string. *)
-
-  val fold_right : (char -> 'a -> 'a) -> string -> 'a -> 'a
-  (** Iterate over the characters in a string in reverse order. *)
-
   val isspace : char -> bool
   (** True if the character is whitespace *)
 
@@ -49,9 +34,6 @@ module String : sig
   val has_substr : string -> string -> bool
   (** True if sub is a substr of str *)
 
-  val find_all : string -> string -> int list
-  (** find all occurences of needle in haystack and return all their respective index *)
-
   val replace : string -> string -> string -> string
   (** replace all [f] substring in [s] by [t] *)
 
@@ -63,10 +45,4 @@ module String : sig
 
   val sub_to_end : string -> int -> string
   (** a substring from the specified position to the end of the string *)
-
-  val sub_before : char -> string -> string
-  (** a substring from the start of the string to the first occurrence of a given character, excluding the character *)
-
-  val sub_after : char -> string -> string
-  (** a substring from  the first occurrence of a given character to the end of the string, excluding the character *)
 end

ocaml/libs/xapi-stdext/lib/xapi-stdext-std/xstringext_test.ml

@@ -27,22 +27,6 @@ let test_list tested_f (name, case, expected) =
   in
   (name, `Quick, check)
 
-let test_rev_map =
-  let spec_rev = [("", ""); ("foo bar", "rab oof")] in
-  let spec_func = [("id", Fun.id); ("uppercase_ascii", Char.uppercase_ascii)] in
-  let test (f_name, f) (case, expected) =
-    let expected = String.map f expected in
-    let name =
-      Printf.sprintf {|"%s" produces "%s" (%s)|} case expected f_name
-    in
-    test_string (XString.rev_map f) (name, case, expected)
-  in
-  let tests =
-    (* Generate the product of the two lists to generate the tests *)
-    List.concat_map (fun func -> List.map (test func) spec_rev) spec_func
-  in
-  ("rev_map", tests)
-
 let test_split =
   let test limit (splitter, splitted, expected) =
     let split = XString.split ~limit in
@@ -168,11 +152,4 @@ let test_escaped =
 
 let () =
   Alcotest.run "Xstringext"
-    [
-      test_rev_map
-    ; test_split
-    ; test_split_f
-    ; test_has_substr
-    ; test_rtrim
-    ; test_escaped
-    ]
+    [test_split; test_split_f; test_has_substr; test_rtrim; test_escaped]