Skip to content

Commit f9db34b

Browse files
committed
qcow_tool_wrapper: Add note on using header information from VHD files
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
1 parent a52b126 commit f9db34b

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

ocaml/xapi/qcow_tool_wrapper.ml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,11 @@ let send ?relative_to (progress_cb : int -> unit) (unix_fd : Unix.file_descr)
6060
to avoid reading all of the raw disk *)
6161
let input_fd = Result.map read_header qcow_path |> Result.to_option in
6262

63+
(* TODO: If VHD headers are to be consulted as well, qcow2-to-stdout
64+
needs to properly account for cluster_bits. Currently QCOW2 export
65+
from VHD-backed VDIs will just revert to raw, without any
66+
allocation accounting. *)
67+
6368
(* Parse the header of the VDI we are diffing against as well *)
6469
let relative_to_qcow_path =
6570
match relative_to with

0 commit comments

Comments
 (0)