Commit 52670bb
committed
Add missing NUMA stub function
If this is missing *and* you have a new enough Xen with the headers
that defines this NUMA stub, then linking the XAPI unit tests would
fail with:
```
File "ocaml/xenopsd/xc/dune", line 83, characters 7-21:
83 | (name xenops_xc_main)
^^^^^^^^^^^^^^
/usr/bin/ld: ocaml/libs/xenctrl-ext/libxenctrl_ext_stubs.a(xenctrlext_stubs.o): in function `stub_xc_domain_numa_get_node_pages_wrapper':
/home/edvint-670/git/xen-api/_build/default/ocaml/libs/xenctrl-ext/xenctrlext_stubs.c:762:(.text+0x1d61): undefined reference to `stub_xc_domain_numa_get_node_pages'
```
The implementation of that function would be in xenctrl_stubs.c, but the
mock xenctrl here replaces that (the headers come from the real xenctrl,
and declare that this function is implemented).
The way this stub is implemented in xenctrlext in xenopsd is unusual,
because it directly calls another C stub implemented in another library.
None of the other stubs work that way: they usually implement the
functionality themselves.
Signed-off-by: Edwin Török <edwin.torok@citrix.com>1 parent 4ad9974 commit 52670bb
1 file changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
0 commit comments