reviews

Author: natpicone

src/modules/shared/utility/utility.service.ts

@@ -195,7 +195,8 @@ export class UtilityService {
   }
 
   getUniqueishId(): string {
-    return window.crypto.getRandomValues(new Uint32Array(1))[0].toString(36);
+    // crypto is available globally in both window and service worker contexts
+    return crypto.getRandomValues(new Uint32Array(1))[0].toString(36);
   }
 
   @boundMethod
@@ -211,7 +212,7 @@ export class UtilityService {
   }
 
   isBraveBrowser(): boolean {
-    return !angular.isUndefined(window.navigator.brave);
+    return typeof navigator !== 'undefined' && !angular.isUndefined((navigator as any).brave);
   }
 
   @boundMethod

src/modules/webext/webext-background/webext-background.service.ts

@@ -193,11 +193,15 @@ export class WebExtBackgroundService {
     // Strip html tags from message
     const urlRegex = new RegExp(Globals.URL.ValidUrlRegex, 'i');
     const urlInAlert = alert.message.match(urlRegex)?.find(Boolean);
+    // Strip HTML tags from message for notification display
     let messageToDisplay = alert.message;
-    if (urlInAlert && typeof DOMParser !== 'undefined') {
+    if (typeof DOMParser !== 'undefined') {
       messageToDisplay =
         new DOMParser().parseFromString(`<span>${alert.message}</span>`, 'text/xml').firstElementChild.textContent ??
         alert.message;
+    } else {
+      // Fallback for service worker context: strip tags with regex
+      messageToDisplay = alert.message.replace(/<[^>]*>/g, '');
     }
     const options: Notifications.CreateNotificationOptions = {
       iconUrl: `${Globals.PathToAssets}/notification.svg`,

webpack/firefox.config.js

@@ -87,7 +87,7 @@ module.exports = (env, argv) => {
     }
   };
 
-  // Background config: service worker entry point with angular shims (no DOM)
+  // Background config: background script entry point with angular shims (no DOM)
   const backgroundConfig = {
     ...webExtConfig,
     name: 'firefox-background',