FIX | critical bug in chain

Author: xiadnoring

include/std/ManapiChain.hpp

@@ -225,17 +225,15 @@ namespace manapi {
             if (!prev) {
                 m = std::move(this->src_);
                 this->src_ = std::move(next);
+                this->src_->prev = nullptr;
             }
             else {
                 m = std::move(prev->next);
                 prev->next = std::move(next);
-            }
-
-            if (!next) {
-                this->last_ = prev;
-            }
-            else {
-                next->prev = prev;
+                if (prev->next)
+                    prev->next->prev = prev;
+                else
+                    this->last_ = prev;
             }
 
             --this->s_;

tests/test_std.cpp

@@ -1,4 +1,8 @@
 #include "ManapiString.hpp"
+#include "std/ManapiChain.hpp"
+#include "ManapiMath.hpp"
+
+#include <deque>
 
 #include "./utest.h"
 
@@ -43,4 +47,92 @@ UTEST(std_string, str_replace_5) {
     ASSERT_TRUE(9 == res);
 }
 
+UTEST(std_string, chain_1) {
+    manapi::chain<int> a;
+    a.push_back(1);
+    a.push_back(2);
+    ASSERT_TRUE(a.size() == 2);
+    auto a1 = a.back();
+    a.pop_back();
+    ASSERT_TRUE(a1 == 2);
+    auto a2 = a.front();
+    a.pop_front();
+    ASSERT_TRUE(a2 == 1);
+}
+
+UTEST(std_string, chain_2) {
+    manapi::chain<int> a;
+    a.push_back(1);
+    a.push_back(2);
+    ASSERT_TRUE(a.size() == 2);
+    auto a2 = a.front();
+    a.pop_front();
+    ASSERT_TRUE(a2 == 1);
+    auto a1 = a.back();
+    a.pop_back();
+    ASSERT_TRUE(a1 == 2);
+}
+
+UTEST(std_string, chain_3) {
+    manapi::chain<int> a;
+    std::deque<int> b;
+
+    for (int i =0 ; i < 500; i++) {
+        int action = manapi::math::random(0, 8);
+        int s = manapi::math::random(0, 10000);
+        ASSERT_TRUE(a.empty() == b.empty());
+        if (a.empty() || (action % 2 == 0 && action <= 6)) {
+            b.push_back(s);
+            a.push_back(s);
+        }
+        else if (action % 2 == 1 && action <= 6) {
+            b.push_front(s);
+            a.push_front(s);
+        }
+        else if (action % 2==0) {
+            b.pop_back();
+            a.pop_back();
+        }
+        else if (action % 2 == 1) {
+            b.pop_front();
+            a.pop_front();
+        }
+    }
+
+    ASSERT_TRUE(b.size() == a.size());
+
+    int cnt=0;
+
+    auto bit = b.begin();
+    auto ait = a.begin();
+
+    for (; ait != a.end() && bit != b.end(); ait++, bit++) {
+        ASSERT_TRUE(*ait == *bit);
+        cnt++;
+    }
+
+    ASSERT_TRUE(cnt == a.size());
+}
+
+UTEST(std_string, chain_4) {
+    manapi::chain<int> a;
+    std::vector<int> values;
+    std::vector<decltype(a)::chain_iterator> its;
+
+    for (int i =0 ; i < 500; i++) {
+        int s = manapi::math::random(0, 100000);
+        a.push_back(s);
+        its.push_back(a.rbegin());
+        values.push_back(s);
+    }
+
+    for (int i = 0; i < 500; i++) {
+        int p = manapi::math::random(0, a.size() - 1);
+        ASSERT_TRUE(*its[p] == values[p]);
+        a.erase(its[p]);
+        values.erase(values.begin() + p);
+        its.erase(its.begin() + p);
+    }
+}
+
 UTEST_MAIN();