UPD | fix ferror in log & add exception with fmt

Author: xiadnoring

include/ManapiErrors.hpp

@@ -206,6 +206,14 @@ namespace manapi {
          */
         explicit exception (manapi::err_num errnum, std::string_view message);
 
+        /**
+         * initialize exception
+         * @param errnum error code
+         * @param fmt error message. must contains a zero end
+         * @param ... arguments
+         */
+        explicit exception (manapi::err_num errnum, std::string_view fmt, ...);
+
         /**
          * initialize exception
          * @param errnum error code

include/std/ManapiAsyncLogger.hpp

@@ -109,7 +109,7 @@ namespace manapi {
 
         void fdebug (const char *fmt, ...) MANAPIHTTP_NOEXCEPT;
 
-        void ferror (const char *fmt, int error_code, ...) MANAPIHTTP_NOEXCEPT;
+        void ferror (int error_code, const char *fmt, ...) MANAPIHTTP_NOEXCEPT;
 
         void fwarning (const char *fmt, ...) MANAPIHTTP_NOEXCEPT;
     private:

src/ManapiErrors.cpp

@@ -206,6 +206,32 @@ manapi::exception::exception(manapi::err_num errnum, std::string_view message) {
     this->m_data.msg_view(message);
 }
 
+manapi::exception::exception(manapi::err_num errnum, std::string_view fmt, ...) {
+    std::string message;
+
+    va_list args;
+    va_start(args, fmt);
+
+    try {
+        va_list args_copy;
+        va_copy(args_copy, args);
+        std::size_t size = vsnprintf(nullptr, 0, fmt.data(), args_copy);
+        va_end(args_copy);
+
+        message.resize(size);
+        vsnprintf(message.data(), message.size() + 1, fmt.data(), args);
+    }
+    catch (std::exception const &e) {
+        manapi_log_trace(manapi::debug::LOG_TRACE_LOW, "exception failed due to %s",
+            e.what());
+    }
+
+    va_end(args);
+
+    this->m_data.errnum(errnum);
+    this->m_data.msg(std::move(message));
+}
+
 manapi::exception::exception(manapi::err_num errnum, const char *message) {
     this->m_data.errnum(errnum);
     this->m_data.msg_view(message);

src/std/ManapiAsyncLogger.cpp

@@ -134,7 +134,7 @@ void manapi::logger::fdebug(const char *fmt, ...) MANAPIHTTP_NOEXCEPT {
 
 }
 
-void manapi::logger::ferror(const char *fmt, int error_code, ...) MANAPIHTTP_NOEXCEPT {
+void manapi::logger::ferror(int error_code, const char *fmt, ...) MANAPIHTTP_NOEXCEPT {
     va_list args;
     va_start(args, fmt);
     fcallback (logger_type::LOGGER_ERROR, this->m_service, error_code, fmt, args);

tests/test_std.cpp

@@ -1,6 +1,7 @@
 #include "ManapiString.hpp"
 #include "std/ManapiChain.hpp"
 #include "ManapiMath.hpp"
+#include "ManapiErrors.hpp"
 
 #include <deque>
 
@@ -135,4 +136,13 @@ UTEST(std_string, chain_4) {
     }
 }
 
+UTEST(std_exception, exception_fmt) {
+    try {
+        throw manapi::exception (manapi::ERR_INTERNAL, "YOU ARE %s", "LUCKY");
+    }
+    catch (manapi::exception const &e) {
+        ASSERT_TRUE(std::string_view{e.what()} == "YOU ARE LUCKY");
+    }
+}
+
 UTEST_MAIN();