remove: redundant fastcgi intercept error directives from site config stubs (#39)

The `fastcgi_intercept_errors` and `error_page` directives that were
added in #26 are redundant in the site configs, they are not used by
nginx. It is only the main `valet.conf` that nginx uses these directives
from, all others are ignored in sites configs. Also the
`proxy_intercept_errors` directive is not needed either since the
`fastcgi_intercept_errors` directive will also do the same job for
proxied sites.

* Removed `proxy_intercept_errors on;` and `fastcgi_intercept_errors
on;` directives from all proxy and fastcgi locations in the nginx stubs:
`proxy.valet.conf`, `secure.proxy.valet.conf`, `secure.valet.conf`, and
`unsecure.valet.conf`.
* Deleted the custom error page configuration for HTTP 500, 502, 503,
and 504 errors, including the internal `/500.html` location and
references to `VALET_ERROR_TEMPLATE_PATH`, from all affected
configuration stubs.

Author: yCodeTech

cli/stubs/proxy.valet.conf

@@ -38,9 +38,6 @@ server {
         proxy_redirect off;
         proxy_buffering off;
 
-        proxy_intercept_errors on;
-        fastcgi_intercept_errors on;
-
         # Prevent being cached...
         # Code from https://ubiq.co/tech-blog/disable-nginx-cache/
 
@@ -59,14 +56,6 @@ server {
     location ~ /\.ht {
         deny all;
     }
-
-    # Internal server error page. Mainly for PHP errors.
-    error_page 500 502 503 504 /500.html;
-
-    location = /500.html {
-        internal;
-        root "VALET_ERROR_TEMPLATE_PATH";
-    }
 }
 
 server {
@@ -95,20 +84,9 @@ server {
         proxy_set_header   X-Real-IP         $remote_addr;
         proxy_set_header   X-Forwarded-For   $proxy_add_x_forwarded_for;
         proxy_set_header   X-Forwarded-Proto $scheme;
-
-        proxy_intercept_errors on;
-        fastcgi_intercept_errors on;
     }
 
     location ~ /\.ht {
         deny all;
     }
-
-    # Internal server error page. Mainly for PHP errors.
-    error_page 500 502 503 504 /500.html;
-
-    location = /500.html {
-        internal;
-        root "VALET_ERROR_TEMPLATE_PATH";
-    }
 }

cli/stubs/secure.proxy.valet.conf

@@ -48,9 +48,6 @@ server {
         proxy_redirect off;
         proxy_buffering off;
 
-        proxy_intercept_errors on;
-        fastcgi_intercept_errors on;
-
         # Prevent being cached...
         # Code from https://ubiq.co/tech-blog/disable-nginx-cache/
 
@@ -69,12 +66,4 @@ server {
     location ~ /\.ht {
         deny all;
     }
-
-    # Internal server error page. Mainly for PHP errors.
-    error_page 500 502 503 504 /500.html;
-
-    location = /500.html {
-        internal;
-        root "VALET_ERROR_TEMPLATE_PATH";
-    }
 }

cli/stubs/secure.valet.conf

@@ -56,21 +56,11 @@ server {
         fastcgi_param SCRIPT_FILENAME "VALET_SERVER_PATH";
         fastcgi_param HOME 'HOME_PATH';
         fastcgi_param PATH_INFO $fastcgi_path_info;
-
-        fastcgi_intercept_errors on;
     }
 
     location ~ /\.ht {
         deny all;
     }
-
-    # Internal server error page. Mainly for PHP errors.
-    error_page 500 502 503 504 /500.html;
-
-    location = /500.html {
-        internal;
-        root "VALET_ERROR_TEMPLATE_PATH";
-    }
 }
 
 server {
@@ -109,19 +99,9 @@ server {
         fastcgi_param SCRIPT_FILENAME "VALET_SERVER_PATH";
         fastcgi_param HOME 'HOME_PATH';
         fastcgi_param PATH_INFO $fastcgi_path_info;
-
-        fastcgi_intercept_errors on;
     }
 
     location ~ /\.ht {
         deny all;
     }
-
-    # Internal server error page. Mainly for PHP errors.
-    error_page 500 502 503 504 /500.html;
-
-    location = /500.html {
-        internal;
-        root "VALET_ERROR_TEMPLATE_PATH";
-    }
 }

cli/stubs/unsecure.valet.conf

@@ -46,19 +46,9 @@ server {
         fastcgi_param SCRIPT_FILENAME "VALET_SERVER_PATH";
         fastcgi_param HOME 'HOME_PATH';
         fastcgi_param PATH_INFO $fastcgi_path_info;
-
-        fastcgi_intercept_errors on;
     }
 
     location ~ /\.ht {
         deny all;
     }
-
-    # Internal server error page. Mainly for PHP errors.
-    error_page 500 502 503 504 /500.html;
-
-    location = /500.html {
-        internal;
-        root "VALET_ERROR_TEMPLATE_PATH";
-    }
 }