remove: the --debug flag from the share command

The flag is now defunct with the removal of the new CMD window. The flag only prevented the window from opening and forcing output to the terminal. This is NOT a breaking change.

Author: yCodeTech

CHANGELOG.md

@@ -45,6 +45,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
     -   Added new `CommandLine::shellExec` method to execute the command in the terminal, and also be able to return the output as a string to the calling method. This is just a wrapper around the native PHP `shell_exec` function.
 
+### Removed
+
+Removed the `--debug` flag from the `share` command since this is now defunct with the removal of the new CMD window. (Debug only prevented the CMD window opening, forcing errors to be logged directly to the terminal.) (Not a breaking change.)
+
 ## [3.1.6.1](https://github.com/yCodeTech/valet-windows/tree/v3.1.6.1) - 2025-03-11
 
 ### Fixed

cli/Valet/Ngrok.php

@@ -51,11 +51,10 @@ public function run(string $command) {
 	/**
 	 * @param string $site The site
 	 * @param int $port The site's port
-	 * @param bool $debug Allow debug error output
 	 * @param array $options Options/flags to pass to ngrok
 	 * @return void
 	 */
-	public function start(string $site, int $port, $debug = false, array $options = []) {
+	public function start(string $site, int $port, array $options = []) {
 		if ($port === 443 && !$this->hasAuthToken()) {
 			output('Forwarding to local port 443 or a local https:// URL is only available after you sign up.
 Sign up at: <fg=blue>https://ngrok.com/signup</>

cli/valet.php

@@ -797,10 +797,8 @@
 	 * - `-o [option]`
 	 * ---
 	 * `valet share mysite --options domain=example.com//region=eu//request-header-remove="blah blah"`
-	 *
-	 * @param bool $debug Allow error messages to output to the current terminal
 	 */
-	$app->command('share [site] [-o|--options=] [--debug]', function ($input, $site = null, $options = null, $debug = null) {
+	$app->command('share [site] [-o|--options=]', function ($input, $site = null, $options = null) {
 
 		// Send an error if the option shortcut has a =
 		if (str_contains($input, "-o=")) {
@@ -811,7 +809,7 @@
 
 		$options = $options != null ? explode("//", $options) : [];
 
-		Ngrok::start($url, Site::port($url), $debug, $options);
+		Ngrok::start($url, Site::port($url), $options);
 
 	})->descriptions('Share the current working directory site with a publically accessible URL', [
 		"site" => "Optionally, the site name",
@@ -1365,4 +1363,4 @@
 /**
  * Run the application.
  */
-$app->run();
+$app->run();