Skip to content

Commit 610fffc

Browse files
committed
Added "Hide non-overridden prefab variables in scenes" setting (closed #42) + Renamed "Hide redundant prefab variant links" to "Hide non-overridden prefab variables in assets"
1 parent 9fddcab commit 610fffc

3 files changed

Lines changed: 17 additions & 9 deletions

File tree

Plugins/AssetUsageDetector/Editor/AssetUsageDetector.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ public class Parameters
5353
#endif
5454
public bool calculateUnusedObjects = false;
5555
public bool hideDuplicateRows = true;
56-
public bool hideReduntantPrefabVariantLinks = true;
56+
public bool hideNonOverriddenPrefabVariablesInAssets = true;
57+
public bool hideNonOverriddenPrefabVariablesInScenes = false;
5758
public bool noAssetDatabaseChanges = false;
5859
public bool showDetailedProgressBar = true;
5960
}

Plugins/AssetUsageDetector/Editor/AssetUsageDetectorSearchFunctions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1453,7 +1453,7 @@ private void SearchVariablesWithSerializedObject( ReferenceNode referenceNode, b
14531453
{
14541454
bool iteratingVisible = iteratorVisible.NextVisible( true );
14551455
#if UNITY_2018_3_OR_NEWER
1456-
bool searchPrefabOverridesOnly = searchParameters.hideReduntantPrefabVariantLinks && unityObject.IsAsset() && PrefabUtility.GetCorrespondingObjectFromSource( unityObject ) != null;
1456+
bool searchPrefabOverridesOnly = ( ( searchParameters.hideNonOverriddenPrefabVariablesInAssets && unityObject.IsAsset() ) || ( searchParameters.hideNonOverriddenPrefabVariablesInScenes && !unityObject.IsAsset() ) ) && PrefabUtility.GetCorrespondingObjectFromSource( unityObject ) != null;
14571457
#endif
14581458
bool enterChildren;
14591459
do

Plugins/AssetUsageDetector/Editor/AssetUsageDetectorWindow.cs

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ private enum WindowFilter { AlwaysReturnActive, ReturnActiveIfNotLocked, AlwaysR
3535
private const string PREFS_ADDRESSABLES_SUPPORT = "AUD_AddressablesSupport";
3636
private const string PREFS_CALCULATE_UNUSED_OBJECTS = "AUD_FindUnusedObjs";
3737
private const string PREFS_HIDE_DUPLICATE_ROWS = "AUD_HideDuplicates";
38-
private const string PREFS_HIDE_REDUNDANT_PREFAB_VARIANT_LINKS = "AUD_HideRedundantPVariantLinks";
38+
private const string PREFS_HIDE_NON_OVERRIDDEN_PREFAB_VARIABLES_IN_ASSETS = "AUD_HideRedundantPVariantLinks";
39+
private const string PREFS_HIDE_NON_OVERRIDDEN_PREFAB_VARIABLES_IN_SCENES = "AUD_HideRedundantPVarsInScenes";
3940
private const string PREFS_SHOW_PROGRESS = "AUD_Progress";
4041

4142
private static readonly GUIContent windowTitle = new GUIContent( "Asset Usage Detector" );
@@ -93,7 +94,8 @@ private bool IsLocked
9394
private bool searchUnusedMaterialProperties = true;
9495
private bool calculateUnusedObjects = false;
9596
private bool hideDuplicateRows = true;
96-
private bool hideReduntantPrefabVariantLinks = true;
97+
private bool hideNonOverriddenPrefabVariablesInAssets = true;
98+
private bool hideNonOverriddenPrefabVariablesInScenes = false;
9799
private bool noAssetDatabaseChanges = false;
98100
private bool showDetailedProgressBar = true;
99101

@@ -331,7 +333,8 @@ private void ShowAndSearchInternal( IEnumerable<Object> searchObjects, AssetUsag
331333
#endif
332334
calculateUnusedObjects = searchParameters.calculateUnusedObjects;
333335
hideDuplicateRows = searchParameters.hideDuplicateRows;
334-
hideReduntantPrefabVariantLinks = searchParameters.hideReduntantPrefabVariantLinks;
336+
hideNonOverriddenPrefabVariablesInAssets = searchParameters.hideNonOverriddenPrefabVariablesInAssets;
337+
hideNonOverriddenPrefabVariablesInScenes = searchParameters.hideNonOverriddenPrefabVariablesInScenes;
335338
noAssetDatabaseChanges = searchParameters.noAssetDatabaseChanges;
336339
showDetailedProgressBar = searchParameters.showDetailedProgressBar;
337340

@@ -414,7 +417,8 @@ private void SavePrefs()
414417
#endif
415418
EditorPrefs.SetBool( PREFS_CALCULATE_UNUSED_OBJECTS, calculateUnusedObjects );
416419
EditorPrefs.SetBool( PREFS_HIDE_DUPLICATE_ROWS, hideDuplicateRows );
417-
EditorPrefs.SetBool( PREFS_HIDE_REDUNDANT_PREFAB_VARIANT_LINKS, hideReduntantPrefabVariantLinks );
420+
EditorPrefs.SetBool( PREFS_HIDE_NON_OVERRIDDEN_PREFAB_VARIABLES_IN_ASSETS, hideNonOverriddenPrefabVariablesInAssets );
421+
EditorPrefs.SetBool( PREFS_HIDE_NON_OVERRIDDEN_PREFAB_VARIABLES_IN_SCENES, hideNonOverriddenPrefabVariablesInScenes );
418422
EditorPrefs.SetBool( PREFS_SHOW_PROGRESS, showDetailedProgressBar );
419423
}
420424

@@ -436,7 +440,8 @@ private void LoadPrefs()
436440
#endif
437441
calculateUnusedObjects = EditorPrefs.GetBool( PREFS_CALCULATE_UNUSED_OBJECTS, false );
438442
hideDuplicateRows = EditorPrefs.GetBool( PREFS_HIDE_DUPLICATE_ROWS, true );
439-
hideReduntantPrefabVariantLinks = EditorPrefs.GetBool( PREFS_HIDE_REDUNDANT_PREFAB_VARIANT_LINKS, true );
443+
hideNonOverriddenPrefabVariablesInAssets = EditorPrefs.GetBool( PREFS_HIDE_NON_OVERRIDDEN_PREFAB_VARIABLES_IN_ASSETS, true );
444+
hideNonOverriddenPrefabVariablesInScenes = EditorPrefs.GetBool( PREFS_HIDE_NON_OVERRIDDEN_PREFAB_VARIABLES_IN_SCENES, false );
440445
showDetailedProgressBar = EditorPrefs.GetBool( PREFS_SHOW_PROGRESS, true );
441446
}
442447

@@ -583,7 +588,8 @@ private void OnGUI()
583588
calculateUnusedObjects = WordWrappingToggleLeft( "Calculate unused objects", calculateUnusedObjects );
584589
hideDuplicateRows = WordWrappingToggleLeft( "Hide duplicate rows in search results", hideDuplicateRows );
585590
#if UNITY_2018_3_OR_NEWER
586-
hideReduntantPrefabVariantLinks = WordWrappingToggleLeft( "Hide redundant prefab variant links (when the same value is assigned to the same Component of a prefab and its variant(s))", hideReduntantPrefabVariantLinks );
591+
hideNonOverriddenPrefabVariablesInAssets = WordWrappingToggleLeft( "Hide non-overridden prefab variables in assets (references found in non-overridden variables of prefab variants/nested prefabs will be hidden)", hideNonOverriddenPrefabVariablesInAssets );
592+
hideNonOverriddenPrefabVariablesInScenes = WordWrappingToggleLeft( "Hide non-overridden prefab variables in scenes (references found in non-overridden variables of prefab instances will be hidden)", hideNonOverriddenPrefabVariablesInScenes );
587593
#endif
588594
noAssetDatabaseChanges = WordWrappingToggleLeft( "I haven't modified any assets/scenes since the last search (faster search)", noAssetDatabaseChanges );
589595
showDetailedProgressBar = WordWrappingToggleLeft( "Update search progress bar more often (cancelable search) (slower search)", showDetailedProgressBar );
@@ -724,7 +730,8 @@ private void InitiateSearch()
724730
#endif
725731
calculateUnusedObjects = calculateUnusedObjects,
726732
hideDuplicateRows = hideDuplicateRows,
727-
hideReduntantPrefabVariantLinks = hideReduntantPrefabVariantLinks,
733+
hideNonOverriddenPrefabVariablesInAssets = hideNonOverriddenPrefabVariablesInAssets,
734+
hideNonOverriddenPrefabVariablesInScenes = hideNonOverriddenPrefabVariablesInScenes,
728735
noAssetDatabaseChanges = noAssetDatabaseChanges,
729736
showDetailedProgressBar = showDetailedProgressBar
730737
} );

0 commit comments

Comments
 (0)