Fixed exceptions while searching for some URP assets' references due to their overriden GetHashCode functions

yasirkula · yasirkula · commit d57a707678b9 · 2023-03-18T15:12:13.000+03:00
diff --git a/Plugins/AssetUsageDetector/Editor/AssetUsageDetector.cs b/Plugins/AssetUsageDetector/Editor/AssetUsageDetector.cs
@@ -350,7 +350,7 @@ public SearchResult Run( Parameters searchParameters )
 
 				// Initialize the nodes of searched asset(s)
 				foreach( Object obj in objectsToSearchSet )
-					searchedUnityObjects.Add( obj.GetHashCode(), PopReferenceNode( obj ) );
+					searchedUnityObjects.Add( obj.GetInstanceID(), PopReferenceNode( obj ) );
 
 				// Progressbar values
 				int searchProgress = 0;
@@ -672,7 +672,7 @@ private void CalculateUnusedObjects( List<SearchResultGroup> searchResult, out H
 						else
 						{
 							for( Transform parent = ( (GameObject) obj ).transform.parent; parent != null; parent = parent.parent )
-								usedObjectPathsSet.Add( parent.gameObject.GetHashCode().ToString() );
+								usedObjectPathsSet.Add( parent.gameObject.GetInstanceID().ToString() );
 						}
 					}
 				}
@@ -739,13 +739,13 @@ private void CalculateUnusedObjects( List<SearchResultGroup> searchResult, out H
 					if( !searchedTopmostGameObject )
 					{
 						if( obj is GameObject )
-							unusedMainObjectNodes[obj.GetHashCode().ToString()] = node;
+							unusedMainObjectNodes[obj.GetInstanceID().ToString()] = node;
 						else
 							currentSearchResultGroup.AddReference( node );
 					}
 					else // List child GameObject scene objects under their parent GameObject
 					{
-						string dictionaryKey = searchedTopmostGameObject.GetHashCode().ToString();
+						string dictionaryKey = searchedTopmostGameObject.GetInstanceID().ToString();
 						List<ReferenceNode> unusedSubObjectNodesAtPath;
 						if( !unusedSubObjectNodes.TryGetValue( dictionaryKey, out unusedSubObjectNodesAtPath ) )
 							unusedSubObjectNodes[dictionaryKey] = unusedSubObjectNodesAtPath = new List<ReferenceNode>( 2 );
@@ -1012,14 +1012,14 @@ private ReferenceNode SearchObject( object obj )
 				{
 					if( assetsToSearchSet.Count == 0 )
 					{
-						searchedUnityObjects.Add( unityObject.GetHashCode(), null );
+						searchedUnityObjects.Add( unityObject.GetInstanceID(), null );
 						return null;
 					}
 
 					assetPath = AssetDatabase.GetAssetPath( unityObject );
 					if( excludedAssetsPathsSet.Contains( assetPath ) || !AssetHasAnyReference( assetPath ) )
 					{
-						searchedUnityObjects.Add( unityObject.GetHashCode(), null );
+						searchedUnityObjects.Add( unityObject.GetInstanceID(), null );
 						return null;
 					}
 				}
@@ -1089,13 +1089,13 @@ private ReferenceNode SearchObject( object obj )
 				if( !searchingSourceAsset )
 				{
 					if( obj is Object )
-						searchedUnityObjects.Add( unityObject.GetHashCode(), result );
+						searchedUnityObjects.Add( unityObject.GetInstanceID(), result );
 					else
 						searchedObjects.Add( GetNodeObjectHash( obj ), result );
 				}
 				else if( result != null )
 				{
-					result.CopyReferencesTo( searchedUnityObjects[unityObject.GetHashCode()] );
+					result.CopyReferencesTo( searchedUnityObjects[unityObject.GetInstanceID()] );
 					PoolReferenceNode( result );
 				}
 			}
@@ -1229,7 +1229,7 @@ private bool TryGetReferenceNode( object nodeObject, out ReferenceNode reference
 		{
 			if( nodeObject is Object )
 			{
-				if( searchedUnityObjects.TryGetValue( nodeObject.GetHashCode(), out referenceNode ) )
+				if( searchedUnityObjects.TryGetValue( ( (Object) nodeObject ).GetInstanceID(), out referenceNode ) )
 					return true;
 			}
 			else if( searchedObjects.TryGetValue( GetNodeObjectHash( nodeObject ), out referenceNode ) )
@@ -1245,7 +1245,7 @@ private ReferenceNode GetReferenceNode( object nodeObject )
 			ReferenceNode result;
 			if( nodeObject is Object )
 			{
-				int hash = nodeObject.GetHashCode();
+				int hash = ( (Object) nodeObject ).GetInstanceID();
 				if( !searchedUnityObjects.TryGetValue( hash, out result ) || result == null )
 				{
 					result = PopReferenceNode( nodeObject );
diff --git a/Plugins/AssetUsageDetector/Editor/SearchResultTreeView.cs b/Plugins/AssetUsageDetector/Editor/SearchResultTreeView.cs
@@ -299,7 +299,7 @@ private bool GenerateRowsRecursive( TreeViewItem parent, ReferenceNode reference
 					if( linkDescriptions.Count > 0 )
 					{
 						Object prefabObject = PrefabUtility.GetCorrespondingObjectFromSource( unityObject );
-						if( prefabObject && parentData.node.HasLinkToObjectWithDescriptions( prefabObject.GetHashCode(), linkDescriptions ) )
+						if( prefabObject && parentData.node.HasLinkToObjectWithDescriptions( prefabObject.GetInstanceID(), linkDescriptions ) )
 							return false;
 					}
 				}
diff --git a/Plugins/AssetUsageDetector/README.txt b/Plugins/AssetUsageDetector/README.txt
@@ -1,4 +1,4 @@
-= Asset Usage Detector (v2.3.0) =
+= Asset Usage Detector (v2.3.1) =
 
 Online documentation available at: https://github.com/yasirkula/UnityAssetUsageDetector
 E-mail: yasirkula@gmail.com
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "com.yasirkula.assetusagedetector",
   "displayName": "Asset Usage Detector",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "documentationUrl": "https://github.com/yasirkula/UnityAssetUsageDetector",
   "changelogUrl": "https://github.com/yasirkula/UnityAssetUsageDetector/releases",
   "licensesUrl": "https://github.com/yasirkula/UnityAssetUsageDetector/blob/master/LICENSE.txt",

Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,7 @@ public SearchResult Run( Parameters searchParameters )`
`350`	`350`
`351`	`351`	`// Initialize the nodes of searched asset(s)`
`352`	`352`	`foreach( Object obj in objectsToSearchSet )`
`353`		`- searchedUnityObjects.Add( obj.GetHashCode(), PopReferenceNode( obj ) );`
	`353`	`+ searchedUnityObjects.Add( obj.GetInstanceID(), PopReferenceNode( obj ) );`
`354`	`354`
`355`	`355`	`// Progressbar values`
`356`	`356`	`int searchProgress = 0;`
`@@ -672,7 +672,7 @@ private void CalculateUnusedObjects( List<SearchResultGroup> searchResult, out H`
`672`	`672`	`else`
`673`	`673`	`{`
`674`	`674`	`for( Transform parent = ( (GameObject) obj ).transform.parent; parent != null; parent = parent.parent )`
`675`		`- usedObjectPathsSet.Add( parent.gameObject.GetHashCode().ToString() );`
	`675`	`+ usedObjectPathsSet.Add( parent.gameObject.GetInstanceID().ToString() );`
`676`	`676`	`}`
`677`	`677`	`}`
`678`	`678`	`}`
`@@ -739,13 +739,13 @@ private void CalculateUnusedObjects( List<SearchResultGroup> searchResult, out H`
`739`	`739`	`if( !searchedTopmostGameObject )`
`740`	`740`	`{`
`741`	`741`	`if( obj is GameObject )`
`742`		`- unusedMainObjectNodes[obj.GetHashCode().ToString()] = node;`
	`742`	`+ unusedMainObjectNodes[obj.GetInstanceID().ToString()] = node;`
`743`	`743`	`else`
`744`	`744`	`currentSearchResultGroup.AddReference( node );`
`745`	`745`	`}`
`746`	`746`	`else // List child GameObject scene objects under their parent GameObject`
`747`	`747`	`{`
`748`		`- string dictionaryKey = searchedTopmostGameObject.GetHashCode().ToString();`
	`748`	`+ string dictionaryKey = searchedTopmostGameObject.GetInstanceID().ToString();`
`749`	`749`	`List<ReferenceNode> unusedSubObjectNodesAtPath;`
`750`	`750`	`if( !unusedSubObjectNodes.TryGetValue( dictionaryKey, out unusedSubObjectNodesAtPath ) )`
`751`	`751`	`unusedSubObjectNodes[dictionaryKey] = unusedSubObjectNodesAtPath = new List<ReferenceNode>( 2 );`
`@@ -1012,14 +1012,14 @@ private ReferenceNode SearchObject( object obj )`
`1012`	`1012`	`{`
`1013`	`1013`	`if( assetsToSearchSet.Count == 0 )`
`1014`	`1014`	`{`
`1015`		`- searchedUnityObjects.Add( unityObject.GetHashCode(), null );`
	`1015`	`+ searchedUnityObjects.Add( unityObject.GetInstanceID(), null );`
`1016`	`1016`	`return null;`
`1017`	`1017`	`}`
`1018`	`1018`
`1019`	`1019`	`assetPath = AssetDatabase.GetAssetPath( unityObject );`
`1020`	`1020`	`if( excludedAssetsPathsSet.Contains( assetPath ) \|\| !AssetHasAnyReference( assetPath ) )`
`1021`	`1021`	`{`
`1022`		`- searchedUnityObjects.Add( unityObject.GetHashCode(), null );`
	`1022`	`+ searchedUnityObjects.Add( unityObject.GetInstanceID(), null );`
`1023`	`1023`	`return null;`
`1024`	`1024`	`}`
`1025`	`1025`	`}`
`@@ -1089,13 +1089,13 @@ private ReferenceNode SearchObject( object obj )`
`1089`	`1089`	`if( !searchingSourceAsset )`
`1090`	`1090`	`{`
`1091`	`1091`	`if( obj is Object )`
`1092`		`- searchedUnityObjects.Add( unityObject.GetHashCode(), result );`
	`1092`	`+ searchedUnityObjects.Add( unityObject.GetInstanceID(), result );`
`1093`	`1093`	`else`
`1094`	`1094`	`searchedObjects.Add( GetNodeObjectHash( obj ), result );`
`1095`	`1095`	`}`
`1096`	`1096`	`else if( result != null )`
`1097`	`1097`	`{`
`1098`		`- result.CopyReferencesTo( searchedUnityObjects[unityObject.GetHashCode()] );`
	`1098`	`+ result.CopyReferencesTo( searchedUnityObjects[unityObject.GetInstanceID()] );`
`1099`	`1099`	`PoolReferenceNode( result );`
`1100`	`1100`	`}`
`1101`	`1101`	`}`
`@@ -1229,7 +1229,7 @@ private bool TryGetReferenceNode( object nodeObject, out ReferenceNode reference`
`1229`	`1229`	`{`
`1230`	`1230`	`if( nodeObject is Object )`
`1231`	`1231`	`{`
`1232`		`- if( searchedUnityObjects.TryGetValue( nodeObject.GetHashCode(), out referenceNode ) )`
	`1232`	`+ if( searchedUnityObjects.TryGetValue( ( (Object) nodeObject ).GetInstanceID(), out referenceNode ) )`
`1233`	`1233`	`return true;`
`1234`	`1234`	`}`
`1235`	`1235`	`else if( searchedObjects.TryGetValue( GetNodeObjectHash( nodeObject ), out referenceNode ) )`
`@@ -1245,7 +1245,7 @@ private ReferenceNode GetReferenceNode( object nodeObject )`
`1245`	`1245`	`ReferenceNode result;`
`1246`	`1246`	`if( nodeObject is Object )`
`1247`	`1247`	`{`
`1248`		`- int hash = nodeObject.GetHashCode();`
	`1248`	`+ int hash = ( (Object) nodeObject ).GetInstanceID();`
`1249`	`1249`	`if( !searchedUnityObjects.TryGetValue( hash, out result ) \|\| result == null )`
`1250`	`1250`	`{`
`1251`	`1251`	`result = PopReferenceNode( nodeObject );`
Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,7 @@ private bool GenerateRowsRecursive( TreeViewItem parent, ReferenceNode reference`
`299`	`299`	`if( linkDescriptions.Count > 0 )`
`300`	`300`	`{`
`301`	`301`	`Object prefabObject = PrefabUtility.GetCorrespondingObjectFromSource( unityObject );`
`302`		`- if( prefabObject && parentData.node.HasLinkToObjectWithDescriptions( prefabObject.GetHashCode(), linkDescriptions ) )`
	`302`	`+ if( prefabObject && parentData.node.HasLinkToObjectWithDescriptions( prefabObject.GetInstanceID(), linkDescriptions ) )`
`303`	`303`	`return false;`
`304`	`304`	`}`
`305`	`305`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-= Asset Usage Detector (v2.3.0) =`
	`1`	`+= Asset Usage Detector (v2.3.1) =`
`2`	`2`
`3`	`3`	`Online documentation available at: https://github.com/yasirkula/UnityAssetUsageDetector`
`4`	`4`	`E-mail: yasirkula@gmail.com`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "com.yasirkula.assetusagedetector",`
`3`	`3`	`"displayName": "Asset Usage Detector",`
`4`		`- "version": "2.3.0",`
	`4`	`+ "version": "2.3.1",`
`5`	`5`	`"documentationUrl": "https://github.com/yasirkula/UnityAssetUsageDetector",`
`6`	`6`	`"changelogUrl": "https://github.com/yasirkula/UnityAssetUsageDetector/releases",`
`7`	`7`	`"licensesUrl": "https://github.com/yasirkula/UnityAssetUsageDetector/blob/master/LICENSE.txt",`