Skip to content

Commit 63614c7

Browse files
committed
Allow empty lrs-statements anyways
1 parent 6f01e8d commit 63614c7

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

src/xapi_schema/spec.cljc

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1326,13 +1326,8 @@
13261326
(some-> s :statement/object :statement-ref/objectType)
13271327
true)))))
13281328

1329-
;; Statement batches in general, e.g. when being inserted into an LRS, should
1330-
;; allow empty arrays.
1331-
1332-
;; Statement batches being retrieved from an LRS should always be non-emtpy.
1333-
13341329
(s/def ::statements
13351330
(s/coll-of ::statement :into []))
13361331

13371332
(s/def ::lrs-statements
1338-
(s/coll-of ::lrs-statement :into [] :min-count 1))
1333+
(s/coll-of ::lrs-statement :into []))

test/xapi_schema/spec_test.cljc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,5 +636,4 @@
636636
(testing "LRS retrieval statement batch"
637637
(should-satisfy+ ::xs/lrs-statements
638638
[d/statement] ; This statement has ID and other required fields
639-
:bad
640639
[])))

0 commit comments

Comments
 (0)