Skip to content

Commit f790daa

Browse files
committed
LRS-82 Allow empty contextActivities map and fix test
previously the test was pointed at the array which was wrong
1 parent 00cd108 commit f790daa

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/xapi_schema/spec.cljc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -944,10 +944,10 @@
944944
(s/def :context/contextActivities
945945
(conform-ns "contextActivities"
946946
(s/and
947-
(s/keys :req [(or :contextActivities/parent
948-
:contextActivities/grouping
949-
:contextActivities/category
950-
:contextActivities/other)])
947+
(s/keys :opt [:contextActivities/parent
948+
:contextActivities/grouping
949+
:contextActivities/category
950+
:contextActivities/other])
951951
(restrict-keys :contextActivities/parent
952952
:contextActivities/grouping
953953
:contextActivities/category

test/xapi_schema/spec_test.cljc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -376,8 +376,8 @@
376376
["foo"])))
377377

378378
(deftest context-activities-map-test
379-
(testing "cannot be empty"
380-
(should-not-satisfy ::xs/context-activities {})))
379+
(testing "can be empty"
380+
(should-satisfy :context/contextActivities {})))
381381

382382
(deftest context-test
383383
(testing "can be empty"

0 commit comments

Comments
 (0)