Fix broken tests - and make them easier to read

We were using a assert_equal_strings() helper that was
not asserting anything.

Oups.

Author: dmerejkowsky

cli_ui/tests/test_cli_ui.py

@@ -12,9 +12,11 @@
 import cli_ui
 from cli_ui.tests.conftest import MessageRecorder
 
-
-def assert_equal_strings(a: str, b: str) -> bool:
-    return a.split() == b.split()
+BLUE = colorama.Fore.BLUE
+GREEN = colorama.Fore.GREEN
+RED = colorama.Fore.RED
+RESET_ALL = colorama.Style.RESET_ALL
+BRIGHT = colorama.Style.BRIGHT
 
 
 class SmartTTY(io.StringIO):
@@ -59,16 +61,10 @@ def test_info_stdout_is_a_tty(smart_tty: io.StringIO) -> None:
     )
     # fmt: on
     expected = (
-        colorama.Fore.RED
-        + "this is red "
-        + colorama.Style.RESET_ALL
-        + colorama.Fore.GREEN
-        + "this is green"
-        + colorama.Style.RESET_ALL
-        + "\n"
+        RED + "this is red " + RESET_ALL + GREEN + "this is green" + "\n" + RESET_ALL
     )
     actual = smart_tty.getvalue()
-    assert_equal_strings(actual, expected)
+    assert actual == expected
 
 
 def test_update_title(smart_tty: SmartTTY) -> None:
@@ -78,17 +74,13 @@ def test_update_title(smart_tty: SmartTTY) -> None:
         fileobj=smart_tty,
         update_title=True
     )
-    # fmt: on
     expected = (
-        colorama.ansi.set_title("Something bold")
-        + "Something "
-        + colorama.Style.BRIGHT
-        + "bold"
-        + colorama.Style.RESET_ALL
-        + "\n"
+        "\x1b]0;Something bold\n\x07"
+        f"Something {BRIGHT}bold\n{RESET_ALL}"
     )
+    # fmt: on
     actual = smart_tty.getvalue()
-    assert_equal_strings(actual, expected)
+    assert actual == expected
 
 
 def test_info_stdout_is_not_a_tty(dumb_tty: DumbTTY) -> None:
@@ -101,23 +93,16 @@ def test_info_stdout_is_not_a_tty(dumb_tty: DumbTTY) -> None:
     # fmt: on
     expected = "this is red this is green\n"
     actual = dumb_tty.getvalue()
-    assert_equal_strings(actual, expected)
+    assert actual == expected
 
 
 def test_info_characters(smart_tty: SmartTTY) -> None:
     cli_ui.info(
         "Doing stuff", cli_ui.ellipsis, "sucess", cli_ui.check, fileobj=smart_tty
     )
     actual = smart_tty.getvalue()
-    expected = (
-        "Doing stuff "
-        + colorama.Style.RESET_ALL
-        + "…"
-        + " sucess "
-        + colorama.Fore.GREEN
-        + "✓"
-    )
-    assert_equal_strings(actual, expected)
+    expected = f"Doing stuff {RESET_ALL}{RESET_ALL}… {RESET_ALL}sucess {RESET_ALL}{GREEN}✓ {RESET_ALL}\n{RESET_ALL}"
+    assert actual == expected
 
 
 def test_timestamp(dumb_tty: DumbTTY, toggle_timestamp: None) -> None: