Skip to content

Commit c27dc38

Browse files
chore: update UI views to use Expo 55
1 parent fc62378 commit c27dc38

5 files changed

Lines changed: 21 additions & 22 deletions

File tree

android/src/main/java/com/youversion/reactnativesdk/views/YVPBibleReaderView.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import androidx.compose.ui.Modifier
88
import com.youversion.platform.core.bibles.domain.BibleReference
99
import com.youversion.platform.reader.BibleReader
1010
import expo.modules.kotlin.AppContext
11+
import expo.modules.kotlin.views.ComposableScope
1112
import expo.modules.kotlin.views.ComposeProps
1213
import expo.modules.kotlin.views.ExpoComposeView
1314

@@ -30,7 +31,7 @@ class YVPBibleReaderView(context: Context, appContext: AppContext) :
3031
override val props = BibleReaderViewProps()
3132

3233
@Composable
33-
override fun Content(modifier: Modifier) {
34+
override fun ComposableScope.Content() {
3435
BibleReader(
3536
appName = props.appName.value ?: "",
3637
appSignInMessage = props.signInMessage.value ?: "",

android/src/main/java/com/youversion/reactnativesdk/views/YVPBibleTextView.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import androidx.compose.ui.graphics.Color
1313
import androidx.compose.ui.unit.dp
1414
import expo.modules.kotlin.AppContext
1515
import expo.modules.kotlin.viewevent.EventDispatcher
16+
import expo.modules.kotlin.views.ComposableScope
1617
import expo.modules.kotlin.views.ComposeProps
1718
import expo.modules.kotlin.views.ExpoComposeView
1819

@@ -43,16 +44,16 @@ class YVPBibleTextView(context: Context, appContext: AppContext) :
4344
private val onTap by EventDispatcher()
4445

4546
@Composable
46-
override fun Content(modifier: Modifier) {
47+
override fun ComposableScope.Content() {
4748
// TODO: Replace with actual BibleText composable when Kotlin SDK is ready
4849
Box(
49-
modifier = modifier
50+
modifier = Modifier
5051
.fillMaxWidth()
5152
.padding(16.dp)
5253
) {
5354
Text(
5455
text = "BibleTextView placeholder - versionId: ${props.versionId.value}, " +
55-
"book: ${props.bookUSFM.value}, chapter: ${props.chapter.value}",
56+
"book: ${props.bookUSFM.value}, chapter: ${props.chapter.value}",
5657
color = Color.Gray
5758
)
5859
}

android/src/main/java/com/youversion/reactnativesdk/views/YVPBibleWidgetView.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import androidx.compose.ui.graphics.Color
1414
import androidx.compose.ui.unit.dp
1515
import androidx.compose.ui.unit.sp
1616
import expo.modules.kotlin.AppContext
17+
import expo.modules.kotlin.views.ComposableScope
1718
import expo.modules.kotlin.views.ComposeProps
1819
import expo.modules.kotlin.views.ExpoComposeView
1920

@@ -36,7 +37,7 @@ class YVPBibleWidgetView(context: Context, appContext: AppContext) :
3637
override val props = BibleWidgetViewProps()
3738

3839
@Composable
39-
override fun Content(modifier: Modifier) {
40+
override fun ComposableScope.Content() {
4041
val isDark = when (props.colorScheme.value) {
4142
"dark" -> true
4243
"light" -> false
@@ -45,7 +46,7 @@ class YVPBibleWidgetView(context: Context, appContext: AppContext) :
4546

4647
// TODO: Replace with actual BibleWidget composable when Kotlin SDK is ready
4748
Box(
48-
modifier = modifier
49+
modifier = Modifier
4950
.fillMaxWidth()
5051
.padding(16.dp)
5152
) {

android/src/main/java/com/youversion/reactnativesdk/views/YVPSignInWithYouVersionButton.kt

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,14 @@ import androidx.compose.foundation.isSystemInDarkTheme
55
import androidx.compose.runtime.Composable
66
import androidx.compose.runtime.MutableState
77
import androidx.compose.runtime.mutableStateOf
8-
import androidx.compose.ui.Modifier
98
import androidx.compose.ui.graphics.Shape
109
import com.youversion.platform.ui.views.SignInWithYouVersionButton
1110
import com.youversion.platform.ui.views.SignInWithYouVersionButtonDefaults
1211
import com.youversion.platform.ui.views.SignInWithYouVersionButtonMode
1312
import expo.modules.kotlin.AppContext
14-
import expo.modules.kotlin.views.AutoSizingComposable
13+
import expo.modules.kotlin.views.ComposableScope
1514
import expo.modules.kotlin.views.ComposeProps
16-
import expo.modules.kotlin.views.Direction
1715
import expo.modules.kotlin.views.ExpoComposeView
18-
import java.util.EnumSet
1916

2017
data class SignInWithYouVersionButtonProps(
2118
val mode: MutableState<String?> = mutableStateOf("full"),
@@ -30,16 +27,14 @@ class YVPSignInWithYouVersionButton(context: Context, appContext: AppContext) :
3027
// private val onTap by EventDispatcher()
3128

3229
@Composable
33-
override fun Content(modifier: Modifier) {
34-
AutoSizingComposable(shadowNodeProxy, axis = EnumSet.of(Direction.HORIZONTAL, Direction.VERTICAL)) {
35-
SignInWithYouVersionButton(
36-
mode = mode(),
37-
stroked = stroked(),
38-
shape = shape(),
39-
dark = isDark(),
40-
permissions = { HashSet() }
41-
)
42-
}
30+
override fun ComposableScope.Content() {
31+
SignInWithYouVersionButton(
32+
mode = mode(),
33+
stroked = stroked(),
34+
shape = shape(),
35+
dark = isDark(),
36+
permissions = { HashSet() }
37+
)
4338
}
4439

4540
fun mode(): SignInWithYouVersionButtonMode {

android/src/main/java/com/youversion/reactnativesdk/views/YVPVotdView.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import androidx.compose.ui.Modifier
1313
import androidx.compose.ui.graphics.Color
1414
import androidx.compose.ui.unit.dp
1515
import expo.modules.kotlin.AppContext
16+
import expo.modules.kotlin.views.ComposableScope
1617
import expo.modules.kotlin.views.ComposeProps
1718
import expo.modules.kotlin.views.ExpoComposeView
1819

@@ -27,7 +28,7 @@ class YVPVotdView(context: Context, appContext: AppContext) :
2728
override val props = VotdViewProps()
2829

2930
@Composable
30-
override fun Content(modifier: Modifier) {
31+
override fun ComposableScope.Content() {
3132
val isDark = when (props.colorScheme.value) {
3233
"dark" -> true
3334
"light" -> false
@@ -36,7 +37,7 @@ class YVPVotdView(context: Context, appContext: AppContext) :
3637

3738
// TODO: Replace with actual VerseOfTheDay composable when Kotlin SDK is ready
3839
Box(
39-
modifier = modifier
40+
modifier = Modifier
4041
.fillMaxWidth()
4142
.padding(16.dp)
4243
) {

0 commit comments

Comments
 (0)