Skip to content

Commit 192d573

Browse files
committed
TST: Mark as xfail until
1 parent c8f1a70 commit 192d573

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

dataframe_sql/tests/markers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import pytest
33

44
ibis_not_implemented = pytest.mark.xfail(
5-
raises=(OperationNotDefinedError, NotImplementedError),
5+
raises=(OperationNotDefinedError, NotImplementedError, ValueError),
66
reason="Not implemented in ibis",
77
)
88

dataframe_sql/tests/pandas_sql_functionality_test.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -357,20 +357,26 @@ def test_limit():
357357
pandas_frame = FOREST_FIRES.copy().head(10)
358358
tm.assert_frame_equal(pandas_frame, my_frame)
359359

360-
360+
@ibis_not_implemented
361361
def test_having_multiple_conditions():
362362
"""
363363
Test having clause
364364
:return:
365365
"""
366366
my_frame = query(
367367
"select min(temp) from forest_fires having min(temp) > 2 and "
368-
"max(dc) < 200 or month = 'oct'"
368+
"max(dc) < 200 or max(dc) > 1000"
369369
)
370370
pandas_frame = FOREST_FIRES.copy()
371371
pandas_frame["_col0"] = FOREST_FIRES["temp"]
372372
aggregated_df = pandas_frame.aggregate({"_col0": "min"}).to_frame().transpose()
373-
pandas_frame = aggregated_df[aggregated_df["_col0"] > 2]
373+
max_dc_df = (
374+
FOREST_FIRES["DC"].aggregate({"DC": "max"}).to_frame().reset_index(drop=True)
375+
)
376+
pandas_frame = aggregated_df[
377+
(aggregated_df["_col0"] > 2) & (max_dc_df["DC"] < 200)
378+
| (max_dc_df["DC"] > 1000)
379+
]
374380
tm.assert_frame_equal(pandas_frame, my_frame)
375381

376382

0 commit comments

Comments
 (0)