Skip to content

Commit 3b99d5a

Browse files
author
Erwin Fedasz
authored
Merge pull request #50 from basecrm/v1.2.3
2 parents 3fd141e + f9904bb commit 3b99d5a

7 files changed

Lines changed: 15 additions & 5 deletions

File tree

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
## CHANGELOG
22

3+
v1.2.3 (2017-10-02)
4+
**Features and Improvements**
5+
6+
* Missing source_id in Leads model
7+
* Relax upper version boundary for JSON gem dependency
8+
39
v1.2.2 (2017-04-03)
410
**Features and Improvements**
511

LICENSE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Copyright (c) 2015 BaseCRM developers
1+
Copyright (c) 2015-2017 BaseCRM developers
22

33
MIT License
44

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.2.2
1+
1.2.3

basecrm.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
2121
spec.test_files = Dir["spec/**/*"]
2222

2323
spec.add_dependency "faraday", "~> 0.9", ">= 0.9.0"
24-
spec.add_dependency "json", "~> 1.7", ">= 1.7.7"
24+
spec.add_dependency "json", ">= 1.7.7"
2525

2626
spec.add_development_dependency "rspec", "~> 3.2"
2727
spec.add_development_dependency "rspec-collection_matchers", "~> 1.1"

lib/basecrm/models/lead.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,9 @@ class Lead < Model
6060
# @!attribute [rw] skype
6161
# @return [String] Lead's Skype nickname.
6262
# attr_accessor :skype
63+
# @!attribute [rw] source_id
64+
# @return [Integer] Unique identifier of the Source.
65+
# attr_accessor :source_id
6366
# @!attribute [rw] status
6467
# @return [String] Status of the lead.
6568
# attr_accessor :status

lib/basecrm/services/leads_service.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
module BaseCRM
44
class LeadsService
5-
OPTS_KEYS_TO_PERSIST = Set[:address, :custom_fields, :description, :email, :facebook, :fax, :first_name, :industry, :last_name, :linkedin, :mobile, :organization_name, :owner_id, :phone, :skype, :status, :tags, :title, :twitter, :website]
5+
OPTS_KEYS_TO_PERSIST = Set[:address, :custom_fields, :description, :email, :facebook, :fax, :first_name, :industry, :last_name, :linkedin, :mobile, :organization_name, :owner_id, :phone, :skype, :source_id, :status, :tags, :title, :twitter, :website]
66

77
def initialize(client)
88
@client = client
@@ -34,6 +34,7 @@ def all
3434
# @option options [String] :last_name Last name of the lead.
3535
# @option options [String] :organization_name Organization name of the lead.
3636
# @option options [Integer] :owner_id User ID. Returns all leads owned by that user.
37+
# @option options [Integer] :source_id ID of the Source.
3738
# @option options [Integer] :page (1) Page number to start from. Page numbering starts at 1 and omitting the `page` parameter will return the first page.
3839
# @option options [Integer] :per_page (25) Number of records to return per page. The default limit is *25* and the maximum number that can be returned is *100*.
3940
# @option options [String] :sort_by (updated_at:asc) A field to sort by. The **default** order is **ascending**. If you want to change the sort order to descending, append `:desc` to the field e.g. `sort_by=last_name:desc`.

lib/basecrm/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module BaseCRM
2-
VERSION = "1.2.2"
2+
VERSION = "1.2.3"
33
end

0 commit comments

Comments
 (0)