Skip to content
This repository was archived by the owner on May 1, 2019. It is now read-only.

Commit b65fd39

Browse files
committed
Merge pull request #454 from localheinz/fix/config-key
Fix: Configuration key for GitHub repository
2 parents 8c175c9 + c8fe41e commit b65fd39

4 files changed

Lines changed: 8 additions & 12 deletions

File tree

module/Application/config/module.config.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,9 @@
66
use Psr\Log;
77

88
return [
9-
'zf-modules' => [
10-
'repository' => [
11-
'owner' => 'zendframework',
12-
'name' => 'modules.zendframework.com',
13-
],
9+
'github_repository' => [
10+
'owner' => 'zendframework',
11+
'name' => 'modules.zendframework.com',
1412
],
1513
'router' => [
1614
'routes' => [

module/Application/src/Application/Controller/ContributorsControllerFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public function createService(ServiceLocatorInterface $controllerManager)
2121
/* @var Service\RepositoryRetriever $repositoryRetriever */
2222
$repositoryRetriever = $serviceManager->get(Service\RepositoryRetriever::class);
2323

24-
$repositoryData = $serviceManager->get('Config')['zf-modules']['repository'];
24+
$repositoryData = $serviceManager->get('Config')['github_repository'];
2525

2626
return new ContributorsController(
2727
$repositoryRetriever,

module/Application/src/Application/View/Helper/GitHubRepositoryUrlFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public function createService(ServiceLocatorInterface $serviceLocator)
1818
/* @var HelperPluginManager $serviceLocator */
1919
$serviceManager = $serviceLocator->getServiceLocator();
2020

21-
$config = $serviceManager->get('Config')['zf-modules']['repository'];
21+
$config = $serviceManager->get('Config')['github_repository'];
2222

2323
return new GitHubRepositoryUrl(
2424
$config['owner'],

module/Application/test/ApplicationTest/Integration/Controller/ContributorsControllerTest.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,9 @@ public function testContributorsActionCanBeAccessed()
2525

2626
$config = $this->getApplicationServiceLocator()->get('Config');
2727

28-
$config['zf-modules'] = [
29-
'repository' => [
30-
'owner' => $vendor,
31-
'name' => $name,
32-
],
28+
$config['github_repository'] = [
29+
'owner' => $vendor,
30+
'name' => $name,
3331
];
3432

3533
$repositoryRetriever = $this->getMockBuilder(Service\RepositoryRetriever::class)

0 commit comments

Comments
 (0)