Merge pull request #207 from zero-sum-seattle/issue#206_fix

Issue#206 fix

Author: KCNilssen

mlbstatsapi/models/attendances/attributes.py

@@ -116,9 +116,9 @@ class AttendanceRecords:
     gameshometotal: int
     year: str
     attendanceaverageytd: int
-    attendancetotal: int
     gametype: Union[AttendenceGameType, dict]
     team: Union[Team, dict]
+    attendancetotal: Optional[int] = None
     attendanceaverageaway: Optional[int] = None
     attendanceaveragehome: Optional[int] = None
     attendancehigh: Optional[int] = None

mlbstatsapi/models/game/gamedata/attributes.py

@@ -165,9 +165,9 @@ class GameInfo:
     delaydurationminutes : int
         The length of delay for the game in minutes
     """
-    attendance: int
     firstpitch: str
-    gamedurationminutes: int
+    attendance: Optional[int] = None
+    gamedurationminutes: Optional[int] = None
     delaydurationminutes: Optional[int] = None
 
 

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "python-mlb-statsapi"
-version = "0.5.17"
+version = "0.5.18"
 
 authors = [
   { name="Matthew Spah", email="spahmatthew@gmail.com" },

tests/external_tests/mlb/test_mlb.py

@@ -91,8 +91,8 @@ def test_mlb_get_person_id(self):
 
     def test_mlb_get_person_id_with_sportid(self):
         """mlb get_person_id should return a person id"""
-        id = self.mlb.get_people_id('Fernando Abad', sport_id=11)
-        self.assertEqual(id, [472551])
+        id = self.mlb.get_people_id('Tyler Black', sport_id=11)
+        self.assertEqual(id, [672012])
 
     def test_mlb_get_invalid_person_id(self):
         """mlb get_person_id should return empty list for invalid name"""