compat: add #[AllowDynamicProperties] to ezcBaseStruct and ezcBaseOptions for PHP 8.2+#17
Open
se7enxweb wants to merge 1 commit into
Open
Conversation
…ions PHP 8.2 deprecated dynamic (undeclared) properties and PHP 9 will remove them. Many eZ Components structs rely on dynamic property assignment because ezcBaseStruct and ezcBaseOptions use magic __set()/__get() but do not declare the properties explicitly. Without this attribute, PHP 8.2+ emits deprecation notices and PHP 9+ raises ErrorException for every property access on these base classes, breaking large portions of the component suite. #[AllowDynamicProperties] is the correct BC shim: - Available since PHP 8.2 - Ignored by PHP < 8.2 (parsed as a no-op on older versions) - Signals that the class intentionally uses dynamic properties Affected classes: - ezcBaseStruct (src/struct.php) - ezcBaseOptions (src/options.php) Reported-by: CJW Network security audit 2026-03-01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported-by: CJW Network security audit 2026-03-01
Problem
PHP 8.2 deprecated dynamic (undeclared) properties; PHP 9 removes them.
ezcBaseStructandezcBaseOptionsrely on dynamic property assignment via magic__set()/__get()but do not declare properties explicitly. Without the#[AllowDynamicProperties]attribute, PHP 8.2+ emits deprecation notices on every property access on these base classes (and any subclass that stores data in undeclared properties), and PHP 9 will raiseErrorException.Changes
src/struct.php: Add#[AllowDynamicProperties]beforeclass ezcBaseStructsrc/options.php: Add#[AllowDynamicProperties]beforeabstract class ezcBaseOptionsThe attribute is available since PHP 8.2 and silently ignored by older versions.