Unable to access dupplicate filenames within an archive

[mat813]

Describe the bug
I get zip files from external services, and from time to time, there are duplicate filenames within an archive. I naively use this code to access the archive, and I only get partial content of the archive with it.

for file_number in 0..archive.len() {
    let mut zip_file = archive.by_index(file_number)?;
    let mut buf = Vec::new()
    zip_file.read_to_end(&mut buf)?;
    // stuff
}

To Reproduce
You can use this file test.zip

It does not seem to be possible to access all files in the archive.

Expected behavior
Accessing all the files from the archive.

Desktop (please complete the following information):

• Version 7.0.0 of zip

[Pr0methean]

This occurs because we're using IndexMap to store both the names and indices of files, and IndexMap unfortunately doesn't allow duplicate keys. @mat813 Do you need random access (i.e. to keep using by_index() and not an iterator)? Because if so, then #487 alone won't solve your problem, and the fix will probably be to use a Vec as the owning storage and for lookups by index, and a BTreeMap for lookups by name.

[mat813]

In this specific case, I don't need random access, I simply need to process all the files.
I switched to s-zip since then though.