🎨 Palette: Add proper button roles and keyboard support for OSINT links#105
Conversation
- Added `role="button"` and `aria-haspopup="dialog"` to OSINT `<a>` links across concepts.html, contact.html, and products.html. - Added a keydown listener in `modal.js` to trigger the modal when the "Space" key is pressed and call `e.preventDefault()`. - Updated test_ui.py to verify keyboard accessibility of the modal.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Converted the OSINT
<a>links that trigger the "Situation Report" modal into semantically correct buttons, and added support for triggering them with the Space key. Added a test case to prevent regression.🎯 Why: The OSINT links used
href="#"but triggered JavaScript actions. By default, anchor tags only trigger on "Enter". Users relying on keyboard navigation or screen readers expect elements acting as buttons to also trigger on "Space".📸 Before/After: N/A - purely semantic and interactive update.
♿ Accessibility:
role="button"to inform screen readers of the element's true function.aria-haspopup="dialog"to announce that activating the button opens a modal.Spacekey inmodal.jsand prevented the default page scroll behavior, making it fully usable via keyboard.PR created automatically by Jules for task 11173006033299907264 started by @0m364