🎨 Palette: Improve accessibility for anchor buttons#108
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
role="button"andaria-haspopup="dialog"to the#sitrep-btnanchor tags acrossconcepts.html,contact.html, andproducts.html. Also updated the event listener inmodal.jsto allow keyboard users to trigger the modal using theSpacekey, preventing the default page scrolling behavior. Added a learning entry to.Jules/palette.mdfor this accessible anchor pattern.🎯 Why: While native
<button>tags respond to bothEnterandSpacekeys, native<a>tags only trigger onEnter. When using anchors as buttons (e.g.href="#"), keyboard users and screen readers expect them to respond toSpace. Adding the proper ARIA roles and a dedicatedkeydownhandler ensures consistent, expected behavior for assistive technologies.📸 Before/After: No visual changes. This is purely an accessibility improvement that enhances keyboard navigation and screen reader semantics.
♿ Accessibility: The
role="button"ensures screen readers announce the element correctly, and theSpacekey event listener provides the expected interaction pattern for keyboard users, preventing frustrating page scrolling when trying to open the modal.PR created automatically by Jules for task 8932448095008489918 started by @0m364