Skip to content

🎨 Palette: Make SITREP modal triggers accessible via Spacebar#109

Open
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-aria-spacebar-modal-17204993255363919429
Open

🎨 Palette: Make SITREP modal triggers accessible via Spacebar#109
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-aria-spacebar-modal-17204993255363919429

Conversation

@0m364

@0m364 0m364 commented Jun 9, 2026

Copy link
Copy Markdown
Owner

💡 What: Added role="button" and aria-haspopup="dialog" to the OSINT modal trigger anchors. Also updated modal.js to bind a Spacebar keydown event that opens the modal.
🎯 Why: Native <a> tags only trigger on the Enter key. Keyboard users and screen readers expect elements acting as buttons to also trigger on the Space key.
📸 Before/After: No visual changes, purely accessibility and interaction improvements.
Accessibility: Screen readers will now announce the OSINT links as buttons that open a dialog. Keyboard users can now open the modal using the Spacebar.


PR created automatically by Jules for task 17204993255363919429 started by @0m364

Adds `role="button"` and `aria-haspopup="dialog"` to all `#sitrep-btn` anchors across the site. Updates `modal.js` to listen for the Spacebar keydown event and open the modal while preventing default page scrolling, ensuring the anchor tags behave like native buttons for keyboard users.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant